Finish moving content to ship view on python #136
+265
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evertvorster
previously requested changes
Nov 25, 2024
There was a problem hiding this comment.
Hi there!
Not sure if this error is in Assets or Engine, but the combination of these two branches, I see that orthogonal accelleration for all ships show as 0.
When loading a saved file, the orthogonal accelleration are normal values.
When starting a new campaign, the orthogonal accelleration is also 0 on the Llama.
This has the effect that if you accelerate in a straight line, and then turn a little, your speed never drops back down to 0.
I'm assuming that the orthogonal acceleration is not read properly, or somehow got corrupted.
evertvorster
dismissed
their stale review
The error I saw is in master as well, so not introduced with this pull request. We'll need to fix that one first.
BenjamenMeyer
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
engine: vegastrike/Vega-Strike-Engine-Source#917
Please answer the following:
Code Changes: