Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate degraded speed governor in llama.begin #139

Merged
merged 2 commits into from
Dec 8, 2024

Conversation

evertvorster
Copy link
Contributor

Thank you for submitting a pull request and becoming a contributor to Vega Strike: Upon the Coldest Sea.

Please answer the following:

Code Changes:

Issues:

  • With the new drive implementation in the engine, the beginning llama was stuck at a speed of 120, even after a repair and refuel which would previously bump the speed to be the same as all the other Llamas that you can get in VegaStrike.

Purpose:

  • What is this pull request trying to do? - Recreate historical game play. In effect, the beginning Llama has some issues that sets the speed governor to 120. On the first refuel and repair, these issues are resolved, and then it should have a speed governor setting of 125.
  • What release is this for? - Git master.
  • Is there a project or milestone we should apply this to? - Nope.

Needed to remove the Afterburner_Speed_Governor from llama.begin too, because otherwise the ship would forever be stuck with a less performant overdrive as compared to all the other llamas in the game. With the line removed, overdrive governor gets the default 125 value, which is in line with what the llama.begin would get with the first repair and refuel.
It is highly unlikely that you would actually get to a place where you would purchase an overdrive without first having purchased a repair and refuel. Even if you did, the effect on gameplay would be far less than having a less performant overdrive after a repair and refuel.

This seems to be the most elegant way of re-creating the degraded Llama that the game is started with. 

Removed the Overdrive governor so that the ship gets the default speed for overdrive. It is highly unlikely that you would purchase an overdrive before doing at least the first repair and refuel. Even if you do, the effect on game play is less than forever being stuck with an overdrive that is less performant than the default Llama. 

Tested with a new campaign, and before purchasing a repair and refuel the governor speed is 120. After the repair and refuel the governor speed has changed to 125.
Copy link
Contributor

@royfalk royfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open an issue in engine - ships do not have the option of no afterburner.
Approved.

@evertvorster evertvorster merged commit 4dc044f into vegastrike:master Dec 8, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants