Merge pull request #843 from BenjamenMeyer/bugfix_release_builds_mac-…

…win_0.9.x Bug Fix: Mac/Windows Release Builds
vegastrike · Apr 23, 2024 · 5c18010 · 5c18010
2 parents 603f006 + 090e1af
commit 5c18010
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 16 deletions.
diff --git a/.github/workflows/Windows-Release.yml b/.github/workflows/Windows-Release.yml
@@ -1,4 +1,4 @@
-name: Windows-CI
+name: Windows-Release
 
 # Controls when the action will run.
 on:
@@ -111,10 +111,11 @@ jobs:
           GTEST_COLOR: 1
         run: .\script\test.ps1 -Generator ${{ matrix.cmake-generator }} -EnablePIE ${{ matrix.enable-pie }} -BuildType ${{ matrix.build-type }}
 
-      - name: Upload artifacts 
-        uses: skx/github-action-publish-binaries@44887b225ceca96efd8a912d39c09ad70312af31 # master
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          ARTIFACT_EXT: ${{ matrix.ARTIFACT_EXT }}
-        with:
-          path: "${{ github.workspace }}/**/*.zip"
+      # TODO: Find/write a tool to upload release for Windows
+      # - name: Upload artifacts
+      #  uses: skx/github-action-publish-binaries@44887b225ceca96efd8a912d39c09ad70312af31 # master
+      #  env:
+      #    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      #    ARTIFACT_EXT: ${{ matrix.ARTIFACT_EXT }}
+      #  with:
+      #    path: "${{ github.workspace }}/**/*.zip"
diff --git a/.github/workflows/macos-release.yml b/.github/workflows/macos-release.yml
@@ -1,4 +1,4 @@
-name: 'MacOS-CI'
+name: 'MacOS-Release'
 
 on:
   release:
@@ -99,10 +99,11 @@ jobs:
           GTEST_COLOR: 1
         run: ctest -V
 
-      - name: Upload the artifacts
-        uses: skx/github-action-publish-binaries@44887b225ceca96efd8a912d39c09ad70312af31 # master
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          ARTIFACT_EXT: ${{ matrix.ARTIFACT_EXT }}
-        with:
-          args: "packages/*.${{ matrix.ARTIFACT_EXT }}"
+      # TODO: Find/write a tool to upload release for Mac OS
+      # - name: Upload the artifacts
+      #  uses: skx/github-action-publish-binaries@44887b225ceca96efd8a912d39c09ad70312af31 # master
+      #  env:
+      #    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      #    ARTIFACT_EXT: ${{ matrix.ARTIFACT_EXT }}
+      #  with:
+      #    args: "packages/*.${{ matrix.ARTIFACT_EXT }}"