Skip to content

Commit

Permalink
Feature: lock actions against hash instead of tag
Browse files Browse the repository at this point in the history
  • Loading branch information
BenjamenMeyer committed Nov 24, 2023
1 parent 7542378 commit b54ba9a
Show file tree
Hide file tree
Showing 8 changed files with 28 additions and 17 deletions.
12 changes: 12 additions & 0 deletions .github/workflows/README.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
Vega Strike Git Hub Actions Guidance
====================================

VS will allow many actions that are beneficial to the project.
We also apply the OSSF Score Card to our projects.

To help with reliability of the GH Actions they should be tagged
against the associated release SHA Hash instead of Git Tag.

References
----------
- https://blog.rafaelgss.dev/why-you-should-pin-actions-by-commit-hash
2 changes: 1 addition & 1 deletion .github/workflows/Windows-CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ jobs:
run: .\script\test.ps1 -Generator ${{ matrix.cmake-generator }} -EnablePIE ${{ matrix.enable-pie }} -BuildType ${{ matrix.build-type }}

- name: Upload test results
uses: actions/[email protected]
uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
if: failure()
with:
name: test_results_xml
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:

steps:
- name: Check out repository
uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 #v3.5.3
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 #v4.1.1
with:
fetch-depth: 2

Expand All @@ -33,7 +33,7 @@ jobs:
# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v2
uses: github/codeql-action/init@4b6aa0b07da05d6e43d0e5f9c8596a6532ce1c85 #v2.15.3
with:
languages: ${{ matrix.language }}
tools: codeql-bundle.tar.gz
Expand All @@ -44,6 +44,6 @@ jobs:
script/build
- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v2
uses: github/codeql-action/analyze@4b6aa0b07da05d6e43d0e5f9c8596a6532ce1c85 #v2.15.3
with:
tools: codeql-bundle.tar.gz
5 changes: 2 additions & 3 deletions .github/workflows/fortify-on-demand-scan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,11 @@ jobs:
# Steps represent a sequence of tasks that will be executed as part of the job
steps:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- uses: actions/[email protected]
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 #v4.1.1

- name: Fortify on Demand Scan
# You may pin to the exact commit or the version.
# uses: fortify/gha-setup-fod-uploader@636f3c3a14aec1747eec5242a02c6349e4f3cce6
uses: fortify/[email protected]
uses: fortify/gha-setup-fod-uploader@16e5036c084b26cee63cb0c38cfc2101cc9fd13d #v1.1.3
with:
# FoDUploader version to use
version: latest
4 changes: 2 additions & 2 deletions .github/workflows/gh-actions-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@ jobs:

steps:
- name: Check out repository
uses: actions/[email protected]
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 #v4.1.1
with:
fetch-depth: 2
submodules: false
Expand Down Expand Up @@ -365,7 +365,7 @@ jobs:
# run: ctest -V

- name: Upload test results
uses: actions/[email protected]
uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
if: failure()
with:
name: test_results_xml
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/gh-actions-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ jobs:

steps:
- name: Check out repository
uses: actions/[email protected]
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 #v4.1.1
with:
fetch-depth: 2
submodules: false
Expand All @@ -183,7 +183,7 @@ jobs:
IS_RELEASE: 1
run: script/cibuild $FLAGS
- name: Upload the artifacts
uses: skx/github-action-publish-binaries@master
uses: skx/github-action-publish-binaries@44887b225ceca96efd8a912d39c09ad70312af31 # master
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
ARTIFACT_EXT: ${{ matrix.ARTIFACT_EXT }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/macos-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
run: brew install openal-soft

- name: Check out repository
uses: actions/[email protected]
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 #v4.1.1
with:
fetch-depth: 2
submodules: false
Expand All @@ -92,7 +92,7 @@ jobs:
run: ctest -V

- name: Upload test results
uses: actions/[email protected]
uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
if: failure()
with:
name: test_results_xml
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/scorecards-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:

steps:
- name: "Check out code"
uses: actions/[email protected]
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 #v4.1.1
with:
persist-credentials: false

Expand All @@ -34,7 +34,7 @@ jobs:
gh release download -R octo-org/codeql-bundle --pattern 'codeql-bundle.tar.gz'
- name: "Run analysis"
uses: ossf/[email protected]
uses: ossf/scorecard-action@0864cf19026789058feabb7e87baa5f140aac736 #v2.3.1
with:
results_file: results.sarif
results_format: sarif
Expand All @@ -49,15 +49,15 @@ jobs:

# Upload the results as artifacts (optional).
- name: "Upload artifact"
uses: actions/[email protected]
uses: actions/upload-artifact@a8a3f3ad30e3422c9c7b888a15615d19a852ae32 # v3.1.3
with:
name: SARIF file
path: results.sarif
retention-days: 5

# Upload the results to GitHub's code scanning dashboard.
- name: "Upload to code-scanning"
uses: github/codeql-action/upload-sarif@v2
uses: github/codeql-action/upload-sarif@4b6aa0b07da05d6e43d0e5f9c8596a6532ce1c85 #v2.15.3
with:
sarif_file: results.sarif
tools: codeql-bundle.tar.gz

0 comments on commit b54ba9a

Please sign in to comment.