The game can crash with a vector-out-of-bounds exception in hashers cleanup code

[stephengtuggy]

Known Issues: The game crashed just now, after I left my ship on autopilot for about 20 minutes. It hit a vector-out-of-bounds exception on this line. Hopefully I will have this fixed within another couple of PRs or so. At least we're catching it now, rather than blithely going on into unallocated memory or something of the sort.

Originally posted by @stephengtuggy in #683 (comment)

[LifWirser]

20 mins on autopilot , autopilot should drop close enough to relevent nav point. Assuming you didn't crash you most likely were at "system boundery" . an overflow of somekind would be reasonable

[stephengtuggy]

Perhaps I did reach the system boundary. The game still shouldn't crash. The game should almost never crash. At least not without providing some sort of "soft landing," as #681 discusses.

[BenjamenMeyer]

@stephengtuggy is this still an issue? Can we defer to 0.10.x? Or do we need to close it for releasing 0.9.x?

[stephengtuggy]

@BenjamenMeyer I am definitely of the opinion that this needs to be fixed before releasing 0.9.x.

[BenjamenMeyer]

@BenjamenMeyer I am definitely of the opinion that this needs to be fixed before releasing 0.9.x.

Do we have a plan for fixing it?
It has been in there for several releases already; so probably not a deal breaker. Just want to make sure we have some kind of plan before we commit to delaying 0.9.0 further on account of it.

[stephengtuggy]

I think I have a relatively small change that I can try. I will try to get to it tomorrow.

[stephengtuggy]

I'm pretty sure that this particular source of crashes is now fixed.