More work on destructors, trying to fix crashes #849
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Apr 26, 2024
…wner.h, vega_collection_utils.cpp, and vega_collection_utils.h. In CMakeLists.txt, change C++ standard to C++14. (Hurray!)
|
Closing in favor of #851 , which includes all of the important changes from this PR, plus macOS fixes and more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a pull request and becoming a contributor to the Vega Strike Core Engine.
Please answer the following:
Code Changes:
Related Tickets:
Fixes #837 for 0.9.x
Fixes #716 for 0.9.x
Fixes #685 for 0.9.x
Purpose:
Known Bugs:
The lack of ability to turn left or right is still present. And it's driving me nuts. It was never this bad until a couple of months ago or so. We've got to get this fixed. The game is virtually unplayable in this state.