Forward port 0 7 x changes #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This contributes to the following stories: vegastrike/infrastructure-tracking#1 vegastrike#96 vegastrike/infrastructure-tracking#6
Rename `mesh_tool` to `vegastrike-meshtool`
- Rename the internal static libraries to vegastrike-* per vegastrike#178 - Rename the internal non-distributed binaries to vs-buildenv-* per vegastrike#178
THe CMake directives originally used for adding the documentation files to the installation used some parameters only available in CMake 3.14 and newer. It's a cleaner approach. However, some of the platforms used still use older version of CMake so the limit is what is available in CMake 3.5. This makes the adjustment to correct it so that it still works with CMake 3.5.
BenjamenMeyer
requested review from
ministerofinformation,
stephengtuggy,
Loki1950 and
nabaco
Loki1950
approved these changes
Feb 11, 2021
|
The CodeQL things should be fixed long term; but they're not something this PR touches, so we'll ignore them for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a pull request and becoming a contributor to the Vega Strike Core Engine.
Please answer the following:
Code Changes:
Issues:
Purpose: