Draft: Remove unused code related to csv #717
Conversation
The file VegaPersonalities isn't used.
royfalk
requested review from
BenjamenMeyer,
ministerofinformation,
stephengtuggy and
Loki1950
| @@ -173,7 +148,7 @@ static AIEvents::ElemAttrMap *getLogicOrInterrupt(string name, | |||
| vsUMap<string, AIEvents::ElemAttrMap *> &mymap, | |||
| int personalityseed) { | |||
| string append = "agg"; | |||
| static vsUMap<string, string> myappend = getAITypes(); | |||
| static vsUMap<string, string> myappend; | |||
There was a problem hiding this comment.
how will this get populated now?
There was a problem hiding this comment.
If you look at line 113-115, this is what's happening anyway. The file 'VegaPersonalities' doesn't exist in either VS or WCPU. I've trimmed the code but nothing's changed. At least, that was the intention.
I specifically asked @Loki1950, as he's our resident historian for such things.
As I can't figure out from the code what they wanted to do and this appears to be a stub for some future feature, I vote to delete it. If/When we get to developing, we'll hopefully document it as well :)
There was a problem hiding this comment.
I just checked. The file 'VegaPersonalities.csv' does, in fact, exist in PWCU. Three copies of it. One under the 'ai' folder, another under the 'ai.easy' folder, and the third under the 'ai.hard' folder.
There was a problem hiding this comment.
Huh. I actually checked in what I assumed was the repository. Is it something you're running on your computer or is it in the repo as well? If it is, can you point me to it?
There was a problem hiding this comment.
|
I absolutely don't understand the purpose of this. However, it also isn't active yet and never will be. The only two ways to figure this out are to ask one of the original devs and hope he remembers after a decade or meditate on the entire AI code and hope it becomes clearer then. |
|
I have a possible reason for it's existence as @stephengtuggy has mentioned it holds the AI profiles of NPC's in the story line since Upon a the Coldest Sea is just a stub ATM that file is not needed yet as it is in Privateer which does have a full story. |
|
Based on the example in the link above, I'll start working on converting it instead of simply deleting the whole function. |
royfalk
changed the title
|
OK. So I looked at the PU data and tried to make it work for VS and it crashed nicely. Looks like I'm going to have to run PU and debug that. |
|
I'm going to close this. The code is needed and I may as well start from scratch. There's nothing here to salvage. |
The file VegaPersonalities.csv isn't used.
@ministerofinformation / @Loki1950 - please let me know if you think this file should have existed and used recently.
Code Changes:
Issues:
Purpose: