Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Big refactor to fix crash in mesh destructor #754

Merged
merged 60 commits into from
Mar 4, 2023
Merged

Big refactor to fix crash in mesh destructor #754

merged 60 commits into from
Mar 4, 2023

Conversation

stephengtuggy
Copy link
Contributor

@stephengtuggy stephengtuggy commented Jan 25, 2023 •
edited
Loading

Thank you for submitting a pull request and becoming a contributor to the Vega Strike Core Engine.

Please answer the following:

Code Changes:

Issues:

Purpose:

  • What is this pull request trying to do? Refactor Mesh; AnimatedTexture; and related classes, to use smart pointers (among other things), for improved memory safety and fewer crashes
  • What release is this for? 0.9.x, preferably
  • Is there a project or milestone we should apply this to? 0.9.x

@stephengtuggy
mesh_gfx.cpp: For removing this from hashers, use approach recomm…
6706949 
…ended by https://www.fluentcpp.com/2018/09/18/how-to-remove-pointers-from-a-vector-in-cpp/
@stephengtuggy
mesh_gfx.cpp: Mesh destructor: For removing this from `undrawn_mesh…
8c8610d 
…es`, use approach recommended by https://www.fluentcpp.com/2018/09/18/how-to-remove-pointers-from-a-vector-in-cpp/
@stephengtuggy
mesh_gfx.cpp: Mesh destructor: For destructing Decal, use approach …
2022b1e 
…recommended by https://www.fluentcpp.com/2018/09/18/how-to-remove-pointers-from-a-vector-in-cpp/
@stephengtuggy
mesh_gfx.cpp, mesh_poly.cpp: Apply CLion code suggestions
cfb1411
@stephengtuggy
5 mesh-related files: Convert bfxmHashTable to a Meyers singleton
69e8804
@stephengtuggy
57 files: WIP
1b82976
@stephengtuggy
97 files: Everything builds again
ed38b26
@stephengtuggy
3 files: GL Light fixes
c82168f
@stephengtuggy
aux_logo.cpp, mesh_gfx.cpp: Fix data type of undrawn_logos
3b687cf
@stephengtuggy
gl_light.cpp, gl_light.h, mesh.cpp, mesh_bxm.cpp: More fixes and refa…
6ddcad1 
…ctorings
@stephengtuggy
star.cpp: Fix Apple build
f708422
@stephengtuggy
mesh.cpp: Another fix
0583adb
@stephengtuggy
mesh refactors
cab5762
@stephengtuggy
Mesh, Sphere: Checkpoint
376b916
@stephengtuggy
Sphere: Checkpoint
f4f390f
@stephengtuggy
sphere.cpp, sphere.h, sphere_generic.cpp: Update copyright year to 2023
31c1dfa
@stephengtuggy
Atmosphere, Mesh, SphereMesh, CityLights: Checkpoint
b0f28aa
@stephengtuggy
Mesh, VSFileSystem: Checkpoint
8cae8c5
@stephengtuggy
mesh_xml.cpp, vsfilesystem.cpp: Disambiguate string_view overloads of…
b41c5e7 
… GetMeshName etc.
@stephengtuggy
Mesh, SphereMesh: shared_from_this called on local object doesn't work
48482e9
@stephengtuggy
mesh.cpp, mesh_fx.cpp, unit_generic.cpp: Game runs again
d199369
@stephengtuggy
sphere.cpp: Try to fix Windows error about array not being defined
5eee4a2
@stephengtuggy
More on Animation, Mesh
4079fc1
@stephengtuggy
animation.cpp, mesh_gfx.cpp: WIP
4ae3a43
@stephengtuggy
gl_light_state.cpp: Attempt to fix gfx_light::lightNum
13d8ebf
@stephengtuggy
gl_light_state.cpp: Finish fixing gfx_light::lightNum
3338251
@stephengtuggy
shared_ptr_hashtable.h: Avoid reentrancy in destructor / Delete()
e33cd65
@stephengtuggy
gl_texture.cpp: textures.at(handle) instead of textures[handle]
dc28dbc
@stephengtuggy
collide.cpp, unit_collide.h: destructor adjustments, etc.
c5f211f
@stephengtuggy
ani_texture.cpp, mesh_gfx.cpp: More null/empty checks
bd425b1
@stephengtuggy stephengtuggy changed the title Fix mesh destructor Fix crash in mesh destructor Feb 27, 2023
@stephengtuggy stephengtuggy added this to the 0.9.x milestone Feb 27, 2023
@stephengtuggy stephengtuggy marked this pull request as ready for review February 27, 2023 04:34
@stephengtuggy stephengtuggy changed the title Fix crash in mesh destructor Big refactor to fix crash in mesh destructor Feb 27, 2023
@stephengtuggy
Copy link
Contributor Author

Known issue: main menu, various other pre-rendered screens not rendering, except for a solid background color. (They are still clickable, however.) (Yeah, this one's kind of a big deal.)

@stephengtuggy
Copy link
Contributor Author

Known issue: Various drawn objects flickering, like the occlusion calculations aren't working correctly, causing the inside or back side of an object to show through.

@stephengtuggy
Copy link
Contributor Author

Known issue: When bolts are fired, game crashes while trying to process them / update their physics. (Fix in progress.)

@stephengtuggy
Copy link
Contributor Author

Known issue: Armor and shield indicators not rendering on VDUs.

This was referenced Mar 4, 2023
Closed
Open
Closed
Open
@stephengtuggy stephengtuggy merged commit 52f438f into vegastrike:master Mar 4, 2023
@evertvorster evertvorster mentioned this pull request Mar 4, 2023
Open
@BenjamenMeyer BenjamenMeyer mentioned this pull request May 8, 2023
Merged
This was referenced May 28, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjamenMeyer BenjamenMeyer BenjamenMeyer approved these changes

@royfalk royfalk Awaiting requested review from royfalk

Assignees

@stephengtuggy stephengtuggy

Labels
bug Proposal
Projects
None yet
Milestone
0.9.x
Development

Successfully merging this pull request may close these issues.

Unit destructor crashes the game
2 participants
@stephengtuggy @BenjamenMeyer