Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the game working on macOS again (without PR 754 changes) #780

Merged
merged 10 commits into from
Jun 7, 2023

Conversation

stephengtuggy
Copy link
Contributor

@stephengtuggy stephengtuggy commented May 24, 2023

Thank you for submitting a pull request and becoming a contributor to the Vega Strike Core Engine.

Please answer the following:

Code Changes:

Issues:

Purpose:

  • What is this pull request trying to do? Get the game working on macOS again, this time without all the changes from the PR 754 refactor. Also, update several of the GitHub Actions to the latest version available.
  • What release is this for? 0.9.x, presumably
  • Is there a project or milestone we should apply this to? 0.9.x, presumably

Additional Notes:

During play testing, I kept encountering crashes after loading certain savegames. (I think that at least some of these may be the same issue previously reported as #761 .) I also hit the crash in the Mesh destructor at least once. (#716 ) And finally, there's the issue with no text on macOS (#786)

@stephengtuggy stephengtuggy self-assigned this May 24, 2023
@stephengtuggy stephengtuggy requested a review from a team May 24, 2023 13:55
@stephengtuggy stephengtuggy linked an issue May 28, 2023 that may be closed by this pull request
engine/src/gldrv/gl_init.cpp Show resolved Hide resolved
@stephengtuggy stephengtuggy merged commit 1fc1e76 into vegastrike:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Actions Migration - Node 12 -> 16
2 participants