Task aug unit

[royfalk]

This is a near complete refactoring of the cloaking in the game.

This is also a move from refactoring using subclasses to fields.
Instead of energetic, we'll have reactor and capacitors.

Not sure why it is picking extra stuff for this PR. It should only have taken 8668683.

Code Changes:

• Have the PR Validation Tests been run? See https://github.com/vegastrike/Vega-Strike-Engine-Source/wiki/Pull-Request-Validation

Game Changes:

• The game now decides if a unit is cloaked if it exceeds its minimum. Before it sometimes used an arbitrary .8. At some point, we'll want to make radars that can pierce at short range, etc. But there are much more urgent tasks.

Issues:

• Game is still fragile. Can't buy a second ship and fly with it.
• I was unable to make the graphics do what I wanted. I wanted cloaked ship to be black and somewhat transparent and glass cloaked ships to be nearly transparent.
• Cloaking takes longer. If an issue, we'll need to adjust rate for ships and modules.
• Cloak can be damaged but can't be repaired (probably). I was unable to find the code to fix modules.

[BenjamenMeyer]

Would be good to have to some instructions for testing this.
Aside from the linting issue this looks good; please fix that. I'll be happy to test it if given some guidance - I haven't had any ships with cloak yet.

[BenjamenMeyer]

linter raising an issue here since it does need to return a value or be refactored to be void.
Perhaps this should be return clock.Visible();?

[royfalk]

Yep.

[royfalk]

Would be good to have to some instructions for testing this.

1. Visual - switch to view 6. Hit c and watch the ship slowly cloak itself and decloak itself.
2. Pick a fight and then cloak yourself and check the enemy doesn't shoot you. He may accidentally ram you...
3. Buy a cloaking device. Sell a cloaking device. The whole upgrade issue has not been tested properly.

[BenjamenMeyer]

@royfalk where can I buy a cloaking device? I have yet to see one.

[stephengtuggy]

@BenjamenMeyer Try buying a cloaking device at an Aera planet or base, maybe? I seem to recall someone saying at some point that Aera bases and planets tend to have cloaking devices, even if others don't.

[BenjamenMeyer]

@stephengtuggy thanks for the suggestion...I'll have to try that out

[royfalk]

I'll wait on this until #792 and #789 are both ready.

[stephengtuggy]

Cool. This code is clean, well organized, well written, and seems quite straightforward. Well done, @royfalk .

I believe you also fixed the linter issue, correct?

[BenjamenMeyer]

agree with @stephengtuggy so approving; will still try to test it out once I can play long enough to find somewhere to buy a clock device from