Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Manjaro Compilation on 0.8.x #808

Merged

Conversation

BenjamenMeyer
Copy link
Member

@BenjamenMeyer BenjamenMeyer commented Oct 29, 2023

Thank you for submitting a pull request and becoming a contributor to the Vega Strike Core Engine.

Please answer the following:

Code Changes:

Issues:

Purpose:

  • What is this pull request trying to do? Compiler error on trying to concat a string and int.
  • What release is this for? 0.8.x
  • Is there a project or milestone we should apply this to? 0.8.x

Compiler error on trying to concat a string and int.
@BenjamenMeyer BenjamenMeyer added this to the 0.8.x milestone Oct 29, 2023
@BenjamenMeyer BenjamenMeyer self-assigned this Oct 29, 2023
@BenjamenMeyer
Copy link
Member Author

NOTE: The Windows build will fail on this one. That will be fixed by #807.

@BenjamenMeyer
Copy link
Member Author

NOTE: I'm mainly working in Golang by day right now...getting lazy about ;... will fix it.

Forgot about using a buffer; fixed.
There is no need to specify the alignment allocator which can
only be used by complex types. The GFXColor and QVector types
are not sufficiently complex to support it; the Vector type
probably is not as well.

For now at least, just use `auto` for the iterators
Copy link
Contributor

@stephengtuggy stephengtuggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stephengtuggy stephengtuggy merged commit 8a7ca30 into vegastrike:0.8.x Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants