Troubleshooting Windows Builds 2023-11-24 #815
Conversation
…cal, instead of stephengtuggy fork
… as default registry
…gtuggy fork; update CMAKE_VERSION
… Evidently homebrew no longer supports it, and runs REALLY slow in som cases
stephengtuggy
added
CI/CD
Compiler Error
…cker-images, including the addition of Ubuntu mantic
|
These 7 CI failures were more or less expected. We don't have a Mantic build image yet. And a 25% success rate for macOS is about as good as we've been able to achieve lately, for whatever reason. (Why 25%? Why not 0% or 100%? This needs further investigation.) |
| echo "Sorry, Ubuntu impish is no longer supported" | ||
| exit 2 | ||
| ;; | ||
| "hirsute") |
There was a problem hiding this comment.
FYI the case functionality can do multi-match via the pipe operator:
case $X in
"value1"|"value2"|"value3")
...
;;
"value4"|"value5")
...
;;
...
esacThere was a problem hiding this comment.
So you would like to combine some of these case clauses that essentially do the same thing?
|
mantic image should be available; I merged the PR so it's just a matter of that getting through |
…rsions we build on
|
Okay, so the Rocky Linux and Fedora 38 failures were NOT expected. It looks like I'm running into #781 here, as well. |
|
Sweet! Looks like the latest fix for Issue 781 is working! (I mostly borrowed the solution from a couple of other people on the Web who were running into similar issues.) |
|
@royfalk I added you as a reviewer in case you're interested in taking a look. Among other things, I'm cutting way back on the number of CI jobs here. I think it was up to over 60 at one point. Now it's down to 31. A bit more manageable. 😄 |
|
Specifically, I derived my fix from nlohmann/json#3895 and https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=64c986b49558a7 Thanks, guys. |
Thank you for submitting a pull request and becoming a contributor to the Vega Strike Core Engine.
Please answer the following:
Code Changes:
Issues:
Closes #813
Fixes #781 for 0.9.x and following
Purpose: