-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Update the GH Actions #817
Merged
BenjamenMeyer
merged 6 commits into
vegastrike:master
from
BenjamenMeyer:bugfix_ossf_scorecard
Nov 27, 2023
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2017210
Enhancement: Update the GH Actions
BenjamenMeyer 9a544c3
Bug Fix: codeql bundle needs to be downloaded
BenjamenMeyer 7542378
Update .github/workflows/Windows-CI.yml
BenjamenMeyer b54ba9a
Feature: lock actions against hash instead of tag
BenjamenMeyer 10bc5af
Bug Fix: Use the right org/repo for the codeql-bundle
BenjamenMeyer 6fea6a8
Merge branch 'master' into bugfix_ossf_scorecard
BenjamenMeyer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
Vega Strike Git Hub Actions Guidance | ||
==================================== | ||
|
||
VS will allow many actions that are beneficial to the project. | ||
We also apply the OSSF Score Card to our projects. | ||
|
||
To help with reliability of the GH Actions they should be tagged | ||
against the associated release SHA Hash instead of Git Tag. | ||
|
||
References | ||
---------- | ||
- https://blog.rafaelgss.dev/why-you-should-pin-actions-by-commit-hash |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can specify a tag to lock to a version or leave out the tag and always get the latest release.
It's not clear from the command-line docs if
gh release download
will work with the SHA hashes of the release so skipping that and just letting it use the latest release.