Homebrew Troubleshooting - 0.8.x #824
Conversation
…rewfile and .github/workflows/macos-ci.yml
…__ are defined, rather than __MACOSX__
…are defined, rather than MACOSX
stephengtuggy
added
CI/CD
Compiler Error
…all list, alongside "[email protected]". Clean up commented-out code
|
Hey, guys. With this PR, 0.8.x should both build consistently and run on macOS. Can I get some reviews, please? And some testing is also needed, esp. on Mac. I will see if I can do some of that. |
Yes, we will probably need to port quite a few of these changes to 0.9.x and to master. Those items will need to be on the project board(s), huh? |
|
So this PR has been merged, judging from the contents of the 0.8.x branch. But the PR screen doesn't show it. Weird. I think I will just close this Pull Request, noting that it has, in fact, been merged. |
|
Hmm. Maybe this PR didn't get merged after all. Reopening. |
|
The Rocky Linux 8.7 failure is expected; the code no longer builds on Rocky Linux 8.x, and as such, I guess we are no longer supporting it. |
* Add Brewfile; add a few entries to .gitignore * Add .github/dependabot.yml and script/bootstrap-on-macos.sh; update Brewfile and .github/workflows/macos-ci.yml * Slight adjustment to macos-ci.yml * ... * ... * Add Brewfile.lock.json, among other things * Add brew update back in * Omit Brewfile.lock.json * gl_init.cpp: Check for macOS by checking whether __APPLE__ and __MACH__ are defined, rather than __MACOSX__ * 22 files: Check for macOS by checking whether __APPLE__ and __MACH__ are defined, rather than MACOSX * Trying yet another approach * bootstrap-on-macos.sh: ... * bootstrap-on-macos.sh: ... * bootstrap-on-macos.sh, macos-ci.yml: Add "[email protected]" to the to-install list, alongside "[email protected]". Clean up commented-out code
|
Good. Now it's merged. |
Thank you for submitting a pull request and becoming a contributor to the Vega Strike Core Engine.
Please answer the following:
Code Changes:
Issues:
Further fixes #812
Purpose: