Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Always run the unit tests #832

Conversation

BenjamenMeyer
Copy link
Member

Thank you for submitting a pull request and becoming a contributor to the Vega Strike Core Engine.

Please answer the following:

Code Changes:

Issues:

  • none

Purpose:

  • What is this pull request trying to do? port CI system bug fix from 0.9.x to master
  • What release is this for? master
  • Is there a project or milestone we should apply this to? master

The Build Process expects to find the output of the tests when doing a release. It is probably wise to run them all the time whether a PR or a release, so let's do so.

The Build Process expects to find the output of the tests when
doing a release. It is probably wise to run them all the time
whether a PR or a release, so let's do so.
@BenjamenMeyer
Copy link
Member Author

#831 but for master

Copy link
Contributor

@stephengtuggy stephengtuggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@stephengtuggy
Copy link
Contributor

The one Windows failure so far was due to what appears to be a temporary error downloading the source for boost-chrono. (HTTP 502)

@BenjamenMeyer BenjamenMeyer merged commit 2eacb16 into vegastrike:master Mar 17, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants