Refactor: CMake Support #889
Conversation
- move the core of the CMake Support to the root - move our CMake modules into a dedicated directory - move all binary targets to a single build directory - disable old CPU optimizations for CPUs that are generally too old to care about any more; compilers tend to do the right thing now - remove unnecessary CMake directives sets; we no longer need to UNSET variables, the CMake Modules should take care of that - Remove all the stuff previously commented out on this branch - Update Windows GH Actions - Update README
| ${Vega_Strike_SOURCE_DIR}/src/resource | ||
| ${Vega_Strike_SOURCE_DIR}/src/components | ||
| ${Vega_Strike_BINARY_DIR} | ||
| ${Vega_Strike_BINARY_DIR}/src |
There was a problem hiding this comment.
NOTE: This gets replaced by the TARGET_INCLUDE_DIRECTORIES on each executable. They don't recommend using INCLUDE_DIRECTORIES any more too.
| OPTION(CPUINTEL_prescott "Enable Intel P4 (sse3) optimizations" OFF ) | ||
| OPTION(CPUINTEL_nocona "Enable Intel P4 (64bit) optimizations" OFF ) | ||
| OPTION(CPUINTEL_core2 "Enable Intel Core2 optimizations" OFF ) | ||
| OPTION(CPUINTEL_native "Enable host-specific optimizations for this machine" OFF ) |
There was a problem hiding this comment.
there are mainly older processors that I would be shocked if someone still had around and was using them to game; also compilers are generally smart enough now to figure out the right optimizations.
There was a problem hiding this comment.
I'm surprised we dropped Sparc and Alpha.
There was a problem hiding this comment.
I'm surprised we dropped Sparc and Alpha.
probably never got migrated to CMake...but yeah...
| OPTION(CPUINTEL_prescott "Enable Intel P4 (sse3) optimizations" OFF ) | ||
| OPTION(CPUINTEL_nocona "Enable Intel P4 (64bit) optimizations" OFF ) | ||
| OPTION(CPUINTEL_core2 "Enable Intel Core2 optimizations" OFF ) | ||
| OPTION(CPUINTEL_native "Enable host-specific optimizations for this machine" OFF ) |
There was a problem hiding this comment.
I'm surprised we dropped Sparc and Alpha.
The `test_asset` directory changed location; update the tests. Also enable the tests at the parent level so it will always be available.
| @@ -45,5 +45,5 @@ else | |||
| fi | |||
|
|
|||
| pushd build | |||
| GTEST_OUTPUT=xml:test-results ctest -V | |||
| GTEST_OUTPUT=xml:$(pwd)/test-results ctest -V | |||
There was a problem hiding this comment.
tests were getting dumped under the engine directory from what I can tell; this should enforce them being in where we expect them to be
|
@royfalk so my goal with the CMake refactor is to start splitting up the source tree a little and enable the ability to separate out things into libraries and binaries in a more flat structure. This first one is just to refactor it into a more standard CMake approach where the CMakeLists.txt lives at the Project Root. |
Replaces #802