Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: Updated Supported Linux Distros #890

Merged
merged 5 commits into from
Oct 12, 2024
Merged

Maintenance: Updated Supported Linux Distros #890

merged 5 commits into from
Oct 12, 2024

Conversation

BenjamenMeyer
Copy link
Member

Code Changes:

@BenjamenMeyer BenjamenMeyer added this to the 0.10.x milestone Oct 5, 2024
@BenjamenMeyer BenjamenMeyer requested review from royfalk, Loki1950 and a team October 5, 2024 16:49
@BenjamenMeyer BenjamenMeyer self-assigned this Oct 5, 2024
royfalk
royfalk approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@royfalk royfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admit I did not review this thoroughly. It looks fine though.
If it were up to me, I'd simplify this somewhat by dropping support even in error message. i.e. only have 'this version of * linux is not supported'.

@BenjamenMeyer
Copy link
Member Author

Trying to figure out what's wrong with the Rocky Linux 8.10 before merging

@BenjamenMeyer
Disable Rocky Linux 8.10
4dbb8c8 
There's some bugs with building on Rocky Linux 8.10.
Disable it until either it completely leaves our support window
or someone in the community that runs Rocky Linux 8.10 steps up
to help fix the issues.
@BenjamenMeyer
Copy link
Member Author

Dropping Rocky Linux 8.10 for the time being

@BenjamenMeyer
Copy link
Member Author

I'd simplify this somewhat by dropping support even in error message. i.e. only have 'this version of * linux is not supported'.

That'd probably a good follow-up PR for to this. Do agree with need to clean things up a bit.

@BenjamenMeyer
Copy link
Member Author

Merging based on #890 (review) and conversation in gitter.im.

@BenjamenMeyer BenjamenMeyer merged commit 332a858 into vegastrike:master Oct 12, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royfalk royfalk royfalk approved these changes

@Loki1950 Loki1950 Awaiting requested review from Loki1950

Assignees

@BenjamenMeyer BenjamenMeyer

Labels
CI/CD
Projects
None yet
Milestone
0.10.x
Development

Successfully merging this pull request may close these issues.
2 participants
@BenjamenMeyer @royfalk