Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug 865 #897

Merged
merged 11 commits into from
Oct 27, 2024
Merged

Fix bug 865 #897

merged 11 commits into from
Oct 27, 2024

Conversation

royfalk
Copy link
Contributor

@royfalk royfalk commented Oct 21, 2024

This fixes #865 .

Please answer the following:

Code Changes:

@royfalk royfalk self-assigned this Oct 21, 2024
Copy link
Contributor

@evertvorster evertvorster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a play test of this change.
Started a new campaign, and saved the game.
The game loads normally, and when launched the ship has yaw controls.
So, that indicates to me that the Llama is properly loaded from a saved game.

From a playability point of view, this is a good step in the right direction.

I was able to complete the training mission, almost.

Setting max speed in maneuver mode is still not enough to satisfy Oswald's requirements, and I had to set travel mode to gather enough speed to pass to the next step in the training mission.

Oswald's last instruction was to purchase a jump drive and then get back to him.
I was not able to purchase the jump drive, despite there being one available on Atlantis, me having enough money and upgrade space in the Llama.

Another thing I noticed was that the fuel burn rate was quite high, and just doing the training mission used about a third of the fuel in the Llama.

After doing a refuel and repair, I also noticed that the fuel was not, in fact, refueled.

The issues noted here I am assuming that it is somewhere else in the code, and I have no problems approving this fix to go in ASAP.

@BenjamenMeyer BenjamenMeyer added this to the 0.10.x milestone Oct 26, 2024
@royfalk royfalk merged commit a9a2228 into master Oct 27, 2024
43 checks passed
@royfalk royfalk deleted the task_bug_865 branch October 27, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save Games with the starting Llama are corrupt in 0.9.x
3 participants