Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug 900 #901

Merged
merged 12 commits into from
Nov 7, 2024
Merged

Fix bug 900 #901

merged 12 commits into from
Nov 7, 2024

Conversation

royfalk
Copy link
Contributor

@royfalk royfalk commented Nov 2, 2024

This fixes the jump damage when jumping.

Please answer the following:

Code Changes:

royfalk added 12 commits December 1, 2023 11:07
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
5e0c681 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
d5f7361 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
d08bfcf 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
5126833 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
7fb35f5 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
ad5c297 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
08daa5b 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
4354d63 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
606f5d4 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
d7dc075 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
b7ce610 
…gine-Source
@royfalk
Fix bug in jump code
ef7d5c3 
that always causes damage during jump.
Attempt to fix drive test.
@royfalk royfalk self-assigned this Nov 2, 2024
@royfalk royfalk mentioned this pull request Nov 2, 2024
Merged
1 task
@royfalk royfalk linked an issue Nov 2, 2024 that may be closed by this pull request
Jump always causes damage to armor #900
Closed
evertvorster
evertvorster approved these changes Nov 3, 2024
View reviewed changes
Copy link
Contributor

@evertvorster evertvorster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this PR against master, and there is no damage when you jump to a new system now. There does not seem to be any other side effects to this PR.

Approved.

@evertvorster evertvorster mentioned this pull request Nov 3, 2024
Merged
2 tasks
BenjamenMeyer
BenjamenMeyer approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@BenjamenMeyer BenjamenMeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable

@royfalk royfalk merged commit 86eb963 into master Nov 7, 2024
43 checks passed
@royfalk royfalk deleted the task_bug_900 branch November 7, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evertvorster evertvorster evertvorster approved these changes

@BenjamenMeyer BenjamenMeyer BenjamenMeyer approved these changes

Assignees

@royfalk royfalk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jump always causes damage to armor
3 participants
@royfalk @BenjamenMeyer @evertvorster