Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch save game to json #922

Merged
merged 15 commits into from
Dec 8, 2024
Merged

Switch save game to json #922

merged 15 commits into from
Dec 8, 2024

Conversation

royfalk
Copy link
Contributor

@royfalk royfalk commented Nov 30, 2024

There is a utility to convert save games to json.

Code Changes:

Issues:

  • None

@royfalk royfalk self-assigned this Nov 30, 2024
@evertvorster
Copy link
Contributor

Not reviewing this yet, but I do have a question.
Is loading older saved games still supported?
If so, will it only save in the new format?

Should this get merged, we need to let users know somehow that they need to back up their old saved games just in case something goes wrong.

@royfalk
Copy link
Contributor Author

royfalk commented Dec 3, 2024

There is a utility to convert save games to json.

I just need to finish polishing it and push it to Assets-Production. I should also add some text to the readme, explaining how to migrate it.

Is loading older saved games still supported?

No

If so, will it only save in the new format?

Yes

Should this get merged, we need to let users know somehow that they need to back up their old saved games just in case something goes wrong.

The unit CSV is left alone. It isn't deleted.

@BenjamenMeyer
Copy link
Member

Is loading older saved games still supported?

No

we should add a script to convert older games to make transition easier; though most likely folks will be starting over

Copy link
Member

@BenjamenMeyer BenjamenMeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it's time to make this happen; we should have some kind of transition though for the saved games; even if it's just a script to do a conversion.

@royfalk royfalk merged commit 06ac77c into master Dec 8, 2024
43 checks passed
@royfalk royfalk deleted the task_save_json branch December 8, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants