Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where some component damage can't be fixed #925

Merged
merged 16 commits into from
Dec 8, 2024
Merged

Fix issue where some component damage can't be fixed #925

merged 16 commits into from
Dec 8, 2024

Conversation

royfalk
Copy link
Contributor

@royfalk royfalk commented Dec 4, 2024 •
edited
Loading

  • Basic Repair to factor damage to these components
  • Make Basic Repair also repair this damage

Please answer the following:

Code Changes:

Issues:

  • FTL drive damage not yet implemented properly - existing issue identified.

fix #916

royfalk added 15 commits December 1, 2023 11:07
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
5e0c681 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
d5f7361 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
d08bfcf 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
5126833 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
7fb35f5 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
ad5c297 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
08daa5b 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
4354d63 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
606f5d4 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
d7dc075 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
b7ce610 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
bd42430 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
4f72ce2 
…gine-Source
@royfalk
Merge branch 'master' of https://github.com/vegastrike/Vega-Strike-En…
a86672e 
…gine-Source
@royfalk
Fix issue where some component damage can't be fixed
cc9d5ad 
- Basic Repair to factor damage to these components
- Make Basic Repair also repair this damage
@royfalk royfalk self-assigned this Dec 4, 2024
@BenjamenMeyer BenjamenMeyer added this to the 0.10.x milestone Dec 7, 2024
BenjamenMeyer
BenjamenMeyer approved these changes Dec 7, 2024
View reviewed changes
Copy link
Member

@BenjamenMeyer BenjamenMeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good to add a comment explaining the added calculation; but otherwise LGTM

@royfalk royfalk merged commit 9b89334 into master Dec 8, 2024
35 checks passed
@royfalk royfalk deleted the task_fix_components branch December 8, 2024 11:47
@BenjamenMeyer
Copy link
Member

Thanks for the comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenjamenMeyer BenjamenMeyer BenjamenMeyer approved these changes

@evertvorster evertvorster Awaiting requested review from evertvorster

Assignees

@royfalk royfalk

Labels
None yet
Projects
None yet
Milestone
0.10.x
Development

Successfully merging this pull request may close these issues.

Llama.begin is not upgraded in game when purchasing the first repair and refuel.
2 participants
@royfalk @BenjamenMeyer