Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: SDL2 Support Round 2 #44

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Enhancement: SDL2 Support Round 2 #44

merged 2 commits into from
Oct 3, 2023

Conversation

BenjamenMeyer
Copy link
Member

Code Changes:

  • This is a documentation change only
  • CI Change

Issues:

Purpose:

  • What is this pull request trying to do? Missed some distros in Enhancement: SDL2 support #43; add them here. Also fix up Funtoo support
  • What release is this for? 0.9.x
  • Is there a project or milestone we should apply this to? 0.9.x

@BenjamenMeyer
Enhancement: SDL2 Support Round 2
28d3324 
- RH/Fedora/SuSe/Manjaro/Rocky
- Fix Funtoo
@BenjamenMeyer BenjamenMeyer added bug Something isn't working enhancement New feature or request labels Oct 1, 2023
@BenjamenMeyer BenjamenMeyer self-assigned this Oct 1, 2023
@BenjamenMeyer
Bug Fix: USE flags
7c808d4 
Gentoo/Funtoo use USE flags to control certain behaviors. For this
image the USE flags just need to change automatically since we
cannot easily control them and we update infrequently.
royfalk
royfalk approved these changes Oct 2, 2023
View reviewed changes
Copy link

@royfalk royfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@BenjamenMeyer
Copy link
Member Author

Merging so we can get SDL2 merged. Will have to fix up Funtoo later

@BenjamenMeyer BenjamenMeyer merged commit 83b7582 into vegastrike:master Oct 3, 2023
51 of 52 checks passed
@stephengtuggy
Copy link
Contributor

Looks like you got it. Nice going. 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Loki1950 Loki1950 Loki1950 approved these changes

@royfalk royfalk royfalk approved these changes

@stephengtuggy stephengtuggy Awaiting requested review from stephengtuggy

Assignees

@BenjamenMeyer BenjamenMeyer

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenjamenMeyer @stephengtuggy @royfalk @Loki1950