Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Custom marker option interface #20

Merged
merged 9 commits into from
Feb 13, 2024
Merged

Conversation

qq7
Copy link
Contributor

@qq7 qq7 commented Jan 31, 2024

No description provided.

@veitbjarsch
Copy link
Owner

Hey, thanks for your PR. I'll look into it the upcoming weekend.

@solesonicsteph
Copy link

Really looking forward to this one getting in! Game changer!

@solesonicsteph
Copy link

Pulled this code down and tested locally via linking, works like a charm! Any updates on when it might be merged @veitbjarsch ?

@dana-futa
Copy link

Exactly what I need for my project! Hope this gets merged soon!

Copy link
Owner

@veitbjarsch veitbjarsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine and demo works well. Just switch from pnpm to npm please. If this is done I'm going to merge it.

pnpm-lock.yaml Outdated Show resolved Hide resolved
Copy link
Owner

@veitbjarsch veitbjarsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Owner

@veitbjarsch veitbjarsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait one more thing 🙈
I missed to tell you can you add the change to the Changelog.md please.

@qq7
Copy link
Contributor Author

qq7 commented Feb 13, 2024

@veitbjarsch sure thing! Should I tag a specific version number?

@veitbjarsch
Copy link
Owner

No just under the unreleased part. It will do it automatically once I release a new version.

@veitbjarsch
Copy link
Owner

Can you put please an:
### Added above the line?

@qq7
Copy link
Contributor Author

qq7 commented Feb 13, 2024

@veitbjarsch done.

Thank you for reacting and for creating this package.

@qq7
Copy link
Contributor Author

qq7 commented Feb 13, 2024

^ deleted pnpm-lock to not clutter up the repo

Copy link
Owner

@veitbjarsch veitbjarsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veitbjarsch veitbjarsch merged commit 1bd7e9e into veitbjarsch:main Feb 13, 2024
3 checks passed
@veitbjarsch
Copy link
Owner

Released new version. Thanks for your effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants