-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Custom marker option interface #20
Conversation
Hey, thanks for your PR. I'll look into it the upcoming weekend. |
Really looking forward to this one getting in! Game changer! |
Pulled this code down and tested locally via linking, works like a charm! Any updates on when it might be merged @veitbjarsch ? |
Exactly what I need for my project! Hope this gets merged soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine and demo works well. Just switch from pnpm to npm please. If this is done I'm going to merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait one more thing 🙈
I missed to tell you can you add the change to the Changelog.md please.
@veitbjarsch sure thing! Should I tag a specific version number? |
No just under the unreleased part. It will do it automatically once I release a new version. |
Can you put please an: |
@veitbjarsch done. Thank you for reacting and for creating this package. |
^ deleted pnpm-lock to not clutter up the repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Released new version. Thanks for your effort. |
No description provided.