Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dry run #125

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Dry run #125

wants to merge 10 commits into from

Conversation

turekj
Copy link

@turekj turekj commented Feb 1, 2017

This PR implements dry-run feature that was mentioned in #120.

I left off where a discussion in #67 has ended. Since #67 seems to be long dead and gone, I decided to start a fresh one with brand new implementation. I also introduced some basic tests that verify the project is not modified and the issues are reported.

Please note that I had no Ruby experience prior to implementing this feature, so any suggestions/comments are more than welcomed.

Last but not least, huge credits to @samdods for starting the original PR!

@noahsark769
Copy link

@turekj this looks really great! Unfortunately, this project pretty much hasn't been updated in 9 months and it doesn't look like there's any active development on it, but I know my team would love to start using this feature.

@marklarr is this still being maintained?

@turekj
Copy link
Author

turekj commented Feb 15, 2017

@noahsark769

There is a way to test this feature. I have created a v0.3 branch in the forked repository cause I needed the feature as my other project dependency. The easiest way to give it a spin is to use bundler:

  1. gem install bundler (if you haven't installed it already)

  2. Create Gemfile in your project directory with following contents:

    gem 'synx', :github => 'turekj/synx', :branch => 'v0.3'
    
  3. Run bundle install.

  4. Test the setup by running bundle exec synx -w warning {ProjectName}.xcodeproj.

If you want it to be attached as a build phase add a following script:

bundle exec synx -w warning ${PROJECT_FILE_PATH}

The other project I am taking about is danger-synx plugin. Your team might be willing to take a look into that too (provided you use any CI server).

@noahsark769
Copy link

@turekj yep, I actually already checked out your branch and ran it on our project - it seems to work great. My eventual goal would be to implement a pre-commit hook that runs synx, but running it on a CI server is also a good thing to have. However, seems like the issue here is that this project hasn't been updated by Venmo in quite a while.

@darrarski
Copy link

👍 Looking forward to see it merged

@gretzki
Copy link

gretzki commented Apr 5, 2017

Hi @turekj ,

thanks for this wonderful addition.
I use it for our CI builds and already proposed a PR to fix a minor issue: turekj#2

Cheers

@zero3nna
Copy link

zero3nna commented May 5, 2017

I'm also looking forward to this feature. Will it be merged soon? Seems like nothing changed for a while in Synx ...

@jadar
Copy link

jadar commented Jul 16, 2018

It's been over a year. Could we get this merged in?

@noahsark769
Copy link

I don’t think Synx is being maintained by Venmo anymore. I’ve been thinking of adding sync functionality to xcodeproj-sort but I think that’s a way off. Unfortunately I don’t think there’s anything to do here at this point.

@turekj
Copy link
Author

turekj commented Jul 16, 2018

I have spoken with @marklarr since he committed to the repo as the last maintainer, but nothing has happened so I think the project won't be maintained anymore. 😭 💀

I could fork it, but considering the latest changes to Xcode I don't think it's much of use for anyone.

@noahsark769
Copy link

I think the project is still pretty useful - it’s still easy to add a folder to the xcodeproj and not make a file system directory. Sad to hear that this won’t be maintained though :(

@jadar
Copy link

jadar commented Jul 16, 2018

@turekj Does Xcode support syncing project with directories natively? Or do you mean it's easier to keep them in sync from scratch, now? I have a few projects that are split into groups with a giant Sources directory that would be nice to sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants