-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dry run #125
base: master
Are you sure you want to change the base?
Dry run #125
Conversation
…fere with original tests
There is a way to test this feature. I have created a v0.3 branch in the forked repository cause I needed the feature as my other project dependency. The easiest way to give it a spin is to use bundler:
If you want it to be attached as a build phase add a following script:
The other project I am taking about is danger-synx plugin. Your team might be willing to take a look into that too (provided you use any CI server). |
@turekj yep, I actually already checked out your branch and ran it on our project - it seems to work great. My eventual goal would be to implement a pre-commit hook that runs synx, but running it on a CI server is also a good thing to have. However, seems like the issue here is that this project hasn't been updated by Venmo in quite a while. |
👍 Looking forward to see it merged |
I'm also looking forward to this feature. Will it be merged soon? Seems like nothing changed for a while in Synx ... |
It's been over a year. Could we get this merged in? |
I don’t think Synx is being maintained by Venmo anymore. I’ve been thinking of adding sync functionality to xcodeproj-sort but I think that’s a way off. Unfortunately I don’t think there’s anything to do here at this point. |
I have spoken with @marklarr since he committed to the repo as the last maintainer, but nothing has happened so I think the project won't be maintained anymore. 😭 💀 I could fork it, but considering the latest changes to Xcode I don't think it's much of use for anyone. |
I think the project is still pretty useful - it’s still easy to add a folder to the xcodeproj and not make a file system directory. Sad to hear that this won’t be maintained though :( |
@turekj Does Xcode support syncing project with directories natively? Or do you mean it's easier to keep them in sync from scratch, now? I have a few projects that are split into groups with a giant Sources directory that would be nice to sync. |
This PR implements dry-run feature that was mentioned in #120.
I left off where a discussion in #67 has ended. Since #67 seems to be long dead and gone, I decided to start a fresh one with brand new implementation. I also introduced some basic tests that verify the project is not modified and the issues are reported.
Please note that I had no Ruby experience prior to implementing this feature, so any suggestions/comments are more than welcomed.
Last but not least, huge credits to @samdods for starting the original PR!