-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VOD deployment job to GitHub workflows #597
Conversation
Switching to "ready for review" just to trigger the CI and see what happens |
d8ac13b
to
4ad81c7
Compare
35a6e04
to
53d05a6
Compare
RFR |
Someone who wants to test the CI on their own machine has to copy-paste quite a lot of shell code from main.yml into a terminal. I wonder if it would be better to move the shell code into a script that one could more easily run manually. Arguably that's a new feature that's distinct from what you're adding here so could be a separate PR, though. And there are various ways one could do it: for example, a single script that runs a different CI job depending on the argument supplied to it? |
@egrimley-arm The way things are implemented, the VOD readme is parsed by the CI script while still being palatable to someone who doesn't care about the CI and just wants to build and run VOD. Finding the right balance between sharing code in the README and having CI-specific code is hard to find, and I reckon the balance we've reached here is not bad. |
I tend to do that when investigating why CI failed, and I also like to run an abbreviated version of the CI tests, rather than follow entirely separate instructions, to check whether a change I've made breaks anything. |
Our CI doesn't include any tests for the freestanding execution engine (FEE), nor any deployments of relatively complex examples.
In this PR we add a job to GitHub workflows that deploys the video object detection example as a standalone binary, in wasmtime, in the FEE and end-to-end.
The changes add about 5min to the
linux
job (need to build Veracruz-Linux in addition to running the tests) and the newvod-full-deployment
job takes about 4min and is executed afterlinux
. This doesn't affect the total execution time since theicecap
job takes more than 30min, which is more thanlinux
andvod-full-deployment
combined.Some ideas to optimise this workflow further (won't be implemented in this PR):