Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gg/devel #2

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
d829e24
WIP add firewall and login form; improve form input fields html; refa…
gggeek Oct 14, 2024
012fe06
Fix: factory method for singleton should not allow different args on …
gggeek Oct 15, 2024
d4962ee
Keep trace of more events in the audit log; update user profile with …
gggeek Oct 15, 2024
513f857
avoid php warning if trying to start a session after headers have bee…
gggeek Oct 15, 2024
1b3d749
add self-service password reset
gggeek Oct 15, 2024
0309d8a
whitespace fixes
gggeek Oct 15, 2024
4ef543c
add support for anti-CSRF tokens; enable it in the password-change fo…
gggeek Oct 15, 2024
88a061e
refactor the form fields class; tie anticsrf tokens to the form showi…
gggeek Oct 16, 2024
8b4324b
complete form field refactoring: avoid double error message in login …
gggeek Oct 16, 2024
e7781ca
one comment
gggeek Oct 16, 2024
8a18622
remove debugging data
gggeek Oct 16, 2024
2bcc140
comments
gggeek Oct 16, 2024
752f4fe
add session limiting, based on redis usage; refactor exceptions hiera…
gggeek Oct 24, 2024
6b5dcb9
do not show rate limiter error messages if there are platform issues;…
gggeek Oct 24, 2024
6c792ae
update readme
gggeek Oct 24, 2024
6104e70
a nitpick
gggeek Oct 24, 2024
346cab0
reset rate-limit of login form on succesful login; refactor names and…
gggeek Oct 25, 2024
bcdaa8f
fix updating users passwords via cli
gggeek Oct 26, 2024
6cbb543
add user::isAuthenticated method
gggeek Oct 28, 2024
bfbfaa0
remove existing anticsrf tokens from the session if switching users
gggeek Oct 28, 2024
7125af4
fix bug when checking for multiple roles; do not always autostart ses…
gggeek Oct 29, 2024
b609975
nitpicks: remove one unused use statement; change order of comparison…
gggeek Oct 29, 2024
b189b8e
implement forgot-password functionality for non-logged-in users; a li…
gggeek Nov 7, 2024
e6f1428
add rate-limiting to forgotpassword forms
gggeek Nov 7, 2024
bf25a20
fix fatal error in case token not in request
gggeek Nov 7, 2024
8ebd302
fix logic of setting errors to forms
gggeek Nov 7, 2024
32fdd05
update readme with expanded installation instructions
gggeek Nov 7, 2024
9306d4c
add support for db indexes and foreign keys
gggeek Nov 7, 2024
cd4dc8b
add support for pgsql and wip suupport for mariadb
gggeek Nov 8, 2024
988a802
update readme and remove dead code after cursory testing on mariadb
gggeek Nov 8, 2024
0a63cfe
Merge branch 'master' into gg/devel-optimizedb
gggeek Nov 13, 2024
f6d405a
add forgotten exit calls after redirects are emitted (for logged-in u…
gggeek Nov 13, 2024
fc9f840
allow disabling the forgotpassword feature
gggeek Nov 13, 2024
dc6c990
modify upload API; allow users to see and delete uploaded data for 1h…
gggeek Nov 15, 2024
c863de3
disable emulated prepared statements to fix running on mariadb
gggeek Nov 15, 2024
8fccabb
update docs
gggeek Nov 15, 2024
d341cf7
feat: allow using urls which omit the trailing .php
gggeek Nov 15, 2024
3b683c4
docs: add a comment about a possible php warning
gggeek Nov 15, 2024
6c7fa5d
feat: allow a different html page title on different pages
gggeek Nov 15, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix logic of setting errors to forms
  • Loading branch information
gggeek committed Nov 7, 2024
commit 8ebd302518c0f431f593318aea735789979d1243
2 changes: 1 addition & 1 deletion src/Form/Form.php
Original file line number Diff line number Diff line change
@@ -158,7 +158,7 @@ protected function getRequest()
public function setError(?string $errorMessage)
{
$this->errorMessage = $errorMessage;
$this->isValid = ($errorMessage !== null && $errorMessage !== '');
$this->isValid = ($errorMessage === null || $errorMessage === '');
}

public function __get($name)
1 change: 0 additions & 1 deletion src/Form/SetNewPasswordForm.php
Original file line number Diff line number Diff line change
@@ -60,7 +60,6 @@ protected function validateSubmit(?array $request = null): void
}
}


public function getUser(): null|User
{
return $this->userConstraint->getUser();