Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Update README for Windows Bash auto-completion and correct… #16

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

Priyanshuthapliyal2005
Copy link
Contributor

This pull request addresses issue #15 by enhancing the documentation to improve clarity on enabling Bash auto-completion on Windows and updating environment path instructions. The key updates include:

Added detailed steps for enabling Bash auto-completion.

Corrected outdated environment path instructions and provided clear examples.

Ensured consistency across the documentation for better readability and user experience.

Please review the changes and provide feedback. Thank you!

… environment paths

Signed-off-by: Priyanshu Thapliyal <[email protected]>
README.md Outdated
```
$ cocli completion bash > ~/.bash_completion.d/cocli
$ . ~/.bash_completion
```

If you are setting up in Windows Bash, you can use:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m unfamiliar with windows bash. Is this more common than powershell, the cmd terminal, or cygwin? Or do you mean through WSL? Please clarify when you say “windows bash”.

grammar thing: colons should not follow verbs, so please remove from “use:”.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve fixed the grammar issue you pointed out regarding the colon after verbs thank you for catching that and, I was referring to Git Bash.

Signed-off-by: Priyanshu Thapliyal <[email protected]>
@deeglaze deeglaze merged commit 21c26de into veraison:main Dec 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants