Skip to content

Commit

Permalink
test(comid): improve ToCBOR and FromCBOR test coverage for env-map
Browse files Browse the repository at this point in the history 
The ToCBOR and FromCBOR have been changed to the following order:
Empty
Class only
Instance only
Group only
Class and Instance
Class and Group
Instance and Group
Class and Instance and Group

The missing tests have also been added.

Signed-off-by: Pranjal Kole <[email protected]>
  • Loading branch information
@pranjalkole
pranjalkole authored Jan 20, 2025
1 parent 834cb46 commit 23deee4
Showing 1 changed file with 142 additions and 23 deletions.
165 changes: 142 additions & 23 deletions comid/environment_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,13 @@ func TestEnvironment_Valid_ok_with_class(t *testing.T) {
assert.Nil(t, err)
}

func TestEnvironment_ToCBOR_empty(t *testing.T) {
var actual Environment
_, err := actual.ToCBOR()

assert.EqualError(t, err, "environment must not be empty")
}

func TestEnvironment_ToCBOR_class_only(t *testing.T) {
tv := Environment{
Class: NewClassUUID(TestUUID),
Expand All @@ -75,6 +82,40 @@ func TestEnvironment_ToCBOR_class_only(t *testing.T) {
assert.Equal(t, expected, actual)
}

func TestEnvironment_ToCBOR_instance_only(t *testing.T) {
tv := Environment{
Instance: MustNewUEIDInstance(TestUEID),
}
require.NotNil(t, tv.Instance)

// {1: 550(h'02DEADBEEFDEAD')}
expected := MustHexDecode(t, "a101d902264702deadbeefdead")

actual, err := tv.ToCBOR()

fmt.Printf("CBOR: %x\n", actual)

assert.Nil(t, err)
assert.Equal(t, expected, actual)
}

func TestEnvironment_ToCBOR_group_only(t *testing.T) {
tv := Environment{
Group: MustNewUUIDGroup(TestUUID),
}
require.NotNil(t, tv.Group)

// {2: 37(h'31FB5ABF023E4992AA4E95F9C1503BFA')}
expected := MustHexDecode(t, "a102d8255031fb5abf023e4992aa4e95f9c1503bfa")

actual, err := tv.ToCBOR()

fmt.Printf("CBOR: %x\n", actual)

assert.Nil(t, err)
assert.Equal(t, expected, actual)
}

func TestEnvironment_ToCBOR_class_and_instance(t *testing.T) {
tv := Environment{
Class: NewClassUUID(TestUUID),
Expand All @@ -94,14 +135,16 @@ func TestEnvironment_ToCBOR_class_and_instance(t *testing.T) {
assert.Equal(t, expected, actual)
}

func TestEnvironment_ToCBOR_instance_only(t *testing.T) {
func TestEnvironment_ToCBOR_class_and_group(t *testing.T) {
tv := Environment{
Instance: MustNewUEIDInstance(TestUEID),
Class: NewClassUUID(TestUUID),
Group: MustNewUUIDGroup(TestUUID),
}
require.NotNil(t, tv.Instance)
require.NotNil(t, tv.Class)
require.NotNil(t, tv.Group)

// {1: 550(h'02DEADBEEFDEAD')}
expected := MustHexDecode(t, "a101d902264702deadbeefdead")
// {0: {0: 37(h'31FB5ABF023E4992AA4E95F9C1503BFA')}, 2: 37(h'31FB5ABF023E4992AA4E95F9C1503BFA')}
expected := MustHexDecode(t, "a200a100d8255031fb5abf023e4992aa4e95f9c1503bfa02d8255031fb5abf023e4992aa4e95f9c1503bfa")

actual, err := tv.ToCBOR()

Expand All @@ -111,14 +154,16 @@ func TestEnvironment_ToCBOR_instance_only(t *testing.T) {
assert.Equal(t, expected, actual)
}

func TestEnvironment_ToCBOR_group_only(t *testing.T) {
func TestEnvironment_ToCBOR_instance_and_group(t *testing.T) {
tv := Environment{
Group: MustNewUUIDGroup(TestUUID),
Instance: MustNewUEIDInstance(TestUEID),
Group: MustNewUUIDGroup(TestUUID),
}
require.NotNil(t, tv.Instance)
require.NotNil(t, tv.Group)

// {2: 37(h'31FB5ABF023E4992AA4E95F9C1503BFA')}
expected := MustHexDecode(t, "a102d8255031fb5abf023e4992aa4e95f9c1503bfa")
// {1: 550(h'02DEADBEEFDEAD'), 2: 37(h'31FB5ABF023E4992AA4E95F9C1503BFA')}
expected := MustHexDecode(t, "a201d902264702deadbeefdead02d8255031fb5abf023e4992aa4e95f9c1503bfa")

actual, err := tv.ToCBOR()

Expand All @@ -128,20 +173,25 @@ func TestEnvironment_ToCBOR_group_only(t *testing.T) {
assert.Equal(t, expected, actual)
}

func TestEnvironment_FromCBOR_empty(t *testing.T) {
tv := MustHexDecode(t, "a0")
func TestEnvironment_ToCBOR_class_and_instance_and_group(t *testing.T) {
tv := Environment{
Class: NewClassUUID(TestUUID),
Instance: MustNewUEIDInstance(TestUEID),
Group: MustNewUUIDGroup(TestUUID),
}
require.NotNil(t, tv.Class)
require.NotNil(t, tv.Instance)
require.NotNil(t, tv.Group)

var actual Environment
err := actual.FromCBOR(tv)
// {0: {0: 37(h'31FB5ABF023E4992AA4E95F9C1503BFA')}, 1: 550(h'02DEADBEEFDEAD'), 2: 37(h'31FB5ABF023E4992AA4E95F9C1503BFA')}
expected := MustHexDecode(t, "a300a100d8255031fb5abf023e4992aa4e95f9c1503bfa01d902264702deadbeefdead02d8255031fb5abf023e4992aa4e95f9c1503bfa")

assert.EqualError(t, err, "environment must not be empty")
}
actual, err := tv.ToCBOR()

func TestEnvironment_ToCBOR_empty(t *testing.T) {
var actual Environment
_, err := actual.ToCBOR()
fmt.Printf("CBOR: %x\n", actual)

assert.EqualError(t, err, "environment must not be empty")
assert.Nil(t, err)
assert.Equal(t, expected, actual)
}

func TestEnvironment_FromCBOR_unknown_map_entry(t *testing.T) {
Expand All @@ -155,6 +205,15 @@ func TestEnvironment_FromCBOR_unknown_map_entry(t *testing.T) {
assert.EqualError(t, err, "environment must not be empty")
}

func TestEnvironment_FromCBOR_empty(t *testing.T) {
tv := MustHexDecode(t, "a0")

var actual Environment
err := actual.FromCBOR(tv)

assert.EqualError(t, err, "environment must not be empty")
}

func TestEnvironment_FromCBOR_class_only(t *testing.T) {
// {0: {0: 37(h'31FB5ABF023E4992AA4E95F9C1503BFA')}}
tv := MustHexDecode(t, "a100a100d8255031fb5abf023e4992aa4e95f9c1503bfa")
Expand All @@ -169,6 +228,34 @@ func TestEnvironment_FromCBOR_class_only(t *testing.T) {
assert.Nil(t, actual.Group)
}

func TestEnvironment_FromCBOR_instance_only(t *testing.T) {
// {1: 550(h'02DEADBEEFDEAD')}
tv := MustHexDecode(t, "a101d902264702deadbeefdead")

var actual Environment
err := actual.FromCBOR(tv)

assert.Nil(t, err)
assert.Nil(t, actual.Class)
assert.NotNil(t, actual.Instance)
assert.Equal(t, []byte(TestUEID), actual.Instance.Bytes())
assert.Nil(t, actual.Group)
}

func TestEnvironment_FromCBOR_group_only(t *testing.T) {
// {2: 37(h'31FB5ABF023E4992AA4E95F9C1503BFA')}
tv := MustHexDecode(t, "a102d8255031fb5abf023e4992aa4e95f9c1503bfa")

var actual Environment
err := actual.FromCBOR(tv)

assert.Nil(t, err)
assert.Nil(t, actual.Class)
assert.Nil(t, actual.Instance)
assert.NotNil(t, actual.Group)
assert.Equal(t, TestUUIDString, actual.Group.String())
}

func TestEnvironment_FromCBOR_class_and_instance(t *testing.T) {
// {0: {0: 37(h'31FB5ABF023E4992AA4E95F9C1503BFA')}, 1: 550(h'02DEADBEEFDEAD')}
tv := MustHexDecode(t, "a200a100d8255031fb5abf023e4992aa4e95f9c1503bfa01d902264702deadbeefdead")
Expand All @@ -184,20 +271,52 @@ func TestEnvironment_FromCBOR_class_and_instance(t *testing.T) {
assert.Nil(t, actual.Group)
}

func TestEnvironment_FromCBOR_group_only(t *testing.T) {
// {2: 37(h'31FB5ABF023E4992AA4E95F9C1503BFA')}
tv := MustHexDecode(t, "a102d8255031fb5abf023e4992aa4e95f9c1503bfa")
func TestEnvironment_FromCBOR_class_and_group(t *testing.T) {
// {0: {0: 37(h'31FB5ABF023E4992AA4E95F9C1503BFA')}, 2: 37(h'31FB5ABF023E4992AA4E95F9C1503BFA')}
tv := MustHexDecode(t, "a200a100d8255031fb5abf023e4992aa4e95f9c1503bfa02d8255031fb5abf023e4992aa4e95f9c1503bfa")

var actual Environment
err := actual.FromCBOR(tv)

assert.Nil(t, err)
assert.Nil(t, actual.Class)
assert.NotNil(t, actual.Class)
assert.Equal(t, TestUUIDString, actual.Class.ClassID.String())
assert.Nil(t, actual.Instance)
assert.NotNil(t, actual.Group)
assert.Equal(t, TestUUIDString, actual.Group.String())
}

func TestEnvironment_FromCBOR_instance_and_group(t *testing.T) {
// {1: 550(h'02DEADBEEFDEAD'), 2: 37(h'31FB5ABF023E4992AA4E95F9C1503BFA')}
tv := MustHexDecode(t, "a201d902264702deadbeefdead02d8255031fb5abf023e4992aa4e95f9c1503bfa")

var actual Environment
err := actual.FromCBOR(tv)

assert.Nil(t, err)
assert.Nil(t, actual.Class)
assert.NotNil(t, actual.Instance)
assert.Equal(t, []byte(TestUEID), actual.Instance.Bytes())
assert.NotNil(t, actual.Group)
assert.Equal(t, TestUUIDString, actual.Group.String())
}

func TestEnvironment_FromCBOR_class_and_instance_and_group(t *testing.T) {
// {0: {0: 37(h'31FB5ABF023E4992AA4E95F9C1503BFA')}, 1: 550(h'02DEADBEEFDEAD'), 2: 37(h'31FB5ABF023E4992AA4E95F9C1503BFA')}
tv := MustHexDecode(t, "a300a100d8255031fb5abf023e4992aa4e95f9c1503bfa01d902264702deadbeefdead02d8255031fb5abf023e4992aa4e95f9c1503bfa")

var actual Environment
err := actual.FromCBOR(tv)

assert.Nil(t, err)
assert.NotNil(t, actual.Class)
assert.Equal(t, TestUUIDString, actual.Class.ClassID.String())
assert.NotNil(t, actual.Instance)
assert.Equal(t, []byte(TestUEID), actual.Instance.Bytes())
assert.NotNil(t, actual.Group)
assert.Equal(t, TestUUIDString, actual.Group.String())
}

func TestEnviroment_JSON(t *testing.T) {
testEnv := Environment{
Class: NewClassUUID(TestUUID),
Expand Down

0 comments on commit 23deee4

Please sign in to comment.