fix some golangci-lint warnings #144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, forgot to add a DCO. Anyways, waiting for a review after which I'll open a new PR with a DCO |
thomas-fossati
approved these changes
Jan 6, 2025
There was a problem hiding this comment.
hi @pranjalkole, thanks for the contribution!
While you are right about this PR not fixing all the lint errors/warnings (see https://github.com/veraison/corim/actions/runs/12573760578/job/35188941045?pr=144#step:7:1), it's still a net improvement that is worth merging.
You don't need to open an new PR, just follow the instructions at https://github.com/veraison/corim/pull/144/checks?check_run_id=35047090555 |
setrofim
approved these changes
Jan 8, 2025
yogeshbdeshpande
approved these changes
Jan 9, 2025
|
hi @pranjalkole, could you please fix the DCO check as per #144 (comment) |
Signed-off-by: Pranjal Kole <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tvparameter in thecborRoundTripperandjsonRoundTripperfunctions to a pointer incots/eat_cwtclaims_test.gocomid/instance_test.go0 == bytes.Compare(a, b)tobytes.Equal(a, b)incots/cas_and_tas_test.gomapLen > math.MaxUint32inencoding/cbor.goThis is a pretty small PR to get familiar with the codebase. I'm also not sure if this would be a useful PR as
make presubmitgives a lot of other errors. Let me know if I should fix the others as well.