Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Improved Extension Points, Their Parent Structures, and Where You Call RegisterExtensions() #145

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ravjot07
Copy link
Contributor

@ravjot07 ravjot07 commented Jan 3, 2025

Contributes toward #137

…ou Call RegisterExtensions()

Signed-off-by: Ravjot Singh <[email protected]>
Copy link
Contributor

@setrofim setrofim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion, LGTM apart from that.

| `corim.Entity` | `corim.ExtEntity` |
| `corim.Signer` | `corim.ExtSigner` |
| `corim.UnsignedCorim` | `corim.ExtUnsignedCorim` |
| Extension Type | Extension Point(s) | Parent Structure | Where to Call RegisterExtensions() |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Extension Type | Extension Point(s) | Parent Structure | Where to Call RegisterExtensions() |
| Extended Type | Extension Point(s) | Parent Structure | Where to Call RegisterExtensions() |

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done @setrofim

Signed-off-by: Ravjot Singh <[email protected]>
@ravjot07
Copy link
Contributor Author

@setrofim i have updated readme. pl review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants