Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Turborepo to v2.3.3 #74736

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Upgrade Turborepo to v2.3.3 #74736

merged 1 commit into from
Jan 10, 2025

Conversation

unstubbable
Copy link
Contributor

This reduces the high CPU usage that was caused by TUI during idle time significantly when running pnpm dev in the Next.js repo.

Running pnpm dev -F next in 4 git worktrees concurrently (as you do)

Before

before

After

after

This reduces the high CPU usage that was caused by TUI during idle time
significantly when running `pnpm dev` in the Next.js repo.
@unstubbable unstubbable requested a review from eps1lon January 10, 2025 09:00
@unstubbable unstubbable enabled auto-merge (squash) January 10, 2025 09:18
@ijjk
Copy link
Member

ijjk commented Jan 10, 2025

Failing test suites

Commit: d1c94b9

pnpm test test/integration/clean-distdir/test/index.test.js

  • Cleaning distDir > production mode > should clean up .next before build start
  • Cleaning distDir > production mode > disabled write > should not clean up .next before build start
Expand output

● Cleaning distDir › production mode › should clean up .next before build start

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  25 |
  26 | const runTests = () => {
> 27 |   it('should clean up .next before build start', async () => {
     |   ^
  28 |     await checkFileWrite(false)
  29 |   })
  30 | }

  at it (integration/clean-distdir/test/index.test.js:27:3)
  at runTests (integration/clean-distdir/test/index.test.js:40:7)
  at integration/clean-distdir/test/index.test.js:33:56
  at Object.describe (integration/clean-distdir/test/index.test.js:32:1)

● Cleaning distDir › production mode › disabled write › should not clean up .next before build start

thrown: "Exceeded timeout of 60000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  56 |         })
  57 |
> 58 |         it('should not clean up .next before build start', async () => {
     |         ^
  59 |           await checkFileWrite(true)
  60 |         })
  61 |       })

  at it (integration/clean-distdir/test/index.test.js:58:9)
  at describe (integration/clean-distdir/test/index.test.js:42:7)
  at integration/clean-distdir/test/index.test.js:33:56
  at Object.describe (integration/clean-distdir/test/index.test.js:32:1)

Read more about building and testing Next.js in contributing.md.

@unstubbable unstubbable merged commit d2c45d0 into canary Jan 10, 2025
123 of 128 checks passed
@unstubbable unstubbable deleted the hl/upgrade-turborepo-2.3.3 branch January 10, 2025 11:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants