chore: Bump socket.io/socket.io-client from ^2 to ^4

[thomashohn]

Resolves #486

[socket-security]

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/[email protected] 🔁 npm/[email protected]	Transitive: environment, filesystem, network, shell	+8	2.62 MB	darrachequesne
npm/[email protected] 🔁 npm/[email protected]	Transitive: environment	+17	2.15 MB	darrachequesne

View full report↗︎

Have feedback? Participate in our User Experience Survey 📊

[styfle]

This is worrisome.

Which lines are we no longer testing?

[thomashohn]

@styfle
I was under the impression that the socket.io/socket.io-client version 4 has a smaller footprint and hence the value for lines had to be adapted - it could be the case that a treshold between 90.0 and 90.85 is the correct value

So it now fails with:
Jest: "global" coverage threshold for lines (90.85%) not met: 90.32%

So 90.32 could be the new "correct" value - or?

[styfle]

The coverage is supposed to be for the src directory. Changing the dependencies shouldn't change coverage.

[thomashohn]

No - but seems to have had an impact - nevertheless

[thomashohn]

Found this faulty path - 'socket.io/lib/index.js' which now is 'socket.io/dist/index.js'
But still the values had to be adapted - maybe the case is special-cases.ts must be adapted - nevertheless with the new path some values still had to bed adapted