this vendors glob-match with unicode support #4571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
10 Ignored Deployments
|
|
✅ This changes can build |
|
Benchmark for 420c192Click to view benchmark
|
gsoltis
requested review from
nathanhammond,
chris-olszewski and
NicholasLYang
and removed request for
mehulkar and
tknickman
Benchmark for 388c861Click to view benchmark
|
chris-olszewski
approved these changes
Apr 13, 2023
Co-authored-by: Chris Olszewski <[email protected]>
Co-authored-by: Chris Olszewski <[email protected]>
There was a problem hiding this comment.
why not a git dependency?
https://doc.rust-lang.org/cargo/reference/overriding-dependencies.html
NicholasLYang
pushed a commit
to NicholasLYang/turbo
that referenced
this pull request
Apr 21, 2023
### Description I have a PR open with glob-match to add unicode grapheme support. This PR vendors the dependency until that lands (devongovett/glob-match#6) ### Testing Instructions `cargo test` <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: Chris Olszewski <[email protected]>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
### Description I have a PR open with glob-match to add unicode grapheme support. This PR vendors the dependency until that lands (devongovett/glob-match#6) ### Testing Instructions `cargo test` <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: Chris Olszewski <[email protected]>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
### Description I have a PR open with glob-match to add unicode grapheme support. This PR vendors the dependency until that lands (devongovett/glob-match#6) ### Testing Instructions `cargo test` <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: Chris Olszewski <[email protected]>
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
### Description I have a PR open with glob-match to add unicode grapheme support. This PR vendors the dependency until that lands (devongovett/glob-match#6) ### Testing Instructions `cargo test` <!-- Give a quick description of steps to test your changes. --> --------- Co-authored-by: Chris Olszewski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have a PR open with glob-match to add unicode grapheme support. This PR vendors the dependency until that lands (devongovett/glob-match#6)
Testing Instructions
cargo test