Update introduction.md #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioolkos
reviewed
May 11, 2023
| @@ -56,3 +56,7 @@ counter.mqtt_connack_sent = 0 | |||
|
|
|||
| All available labels can be show using `vmq-admin metrics show --help`. | |||
|
|
|||
| {% hint style="warning" %} | |||
| VerneMQ is a implemented in Erlang, which is a highly concurrent system, and follows a fail fast machanism. It might happen that in some scenarios the metrics do not seem to "match". One typcial example is sockets_open and sockets_close. In case of failure, the sockets_close metric might not be increased and thus there is a difference between opened sockets and closed sockets. The metric is nonetheless useful when inspecting the the running system. | |||
There was a problem hiding this comment.
This seems to suggest that the metrics are somehow allowed to be wrong. For a Verne lifecycle (boot to boot) we expect metrics to be correct, though. Even socket close and open. If not, we missed a code flow to trigger counters.
After a reboot, those metrics are reset. So, I guess it depends what we mean by "In case of failure" in the snippet.
Just don't want to confuse readers, that's the main thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.