Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<feat>env: add VFOX_* environment variables #414

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

planktonzp
Copy link

Add VFOX_* environment variables to change the location of cache/temp/plugin directory

@planktonzp
Copy link
Author

@aooohan @bytemain could you review this PR? thx

Copy link
Member

@aooohan aooohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the first contribution. However, allowing users to modify these directory paths through environment variables may not convenient. And I think this is not a necessary feature either.

@planktonzp
Copy link
Author

Thanks for the first contribution. However, allowing users to modify these directory paths through environment variables may not convenient. And I think this is not a necessary feature either.

However, if it is placed directly under $HOME and cannot be modified, there will be problems with polluting the directory structure. Some users (such as me) have very limited directory space. At the same time, maybe use XDG_* can be more standardized

Anyway, thanks for taking the time to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants