Add unit tests for deepEncodeKeyWhenUseObjectId for MongoClient

vert-x3 · Nov 8, 2023 · 9053850 · 9053850
1 parent 49adb45
commit 9053850
Show file tree

Hide file tree

Showing 2 changed files with 88 additions and 1 deletion.
diff --git a/src/test/java/io/vertx/ext/mongo/MongoClientWithObjectIdTest.java b/src/test/java/io/vertx/ext/mongo/MongoClientWithObjectIdTest.java
@@ -1,5 +1,6 @@
 package io.vertx.ext.mongo;
 
+import io.vertx.core.json.JsonArray;
 import io.vertx.core.json.JsonObject;
 import org.bson.types.ObjectId;
 import org.junit.Test;
@@ -77,6 +78,32 @@ public void testFindOneReturnsStringId() throws Exception {
     await();
   }
 
+  @Test
+  public void testFindOneWithNestedQueryReturnsStringId() throws Exception {
+    String collection = randomCollection();
+    mongoClient.createCollection(collection).onComplete(onSuccess(res -> {
+      JsonObject orig = createDoc();
+      JsonObject doc = orig.copy();
+      String objectId = getObjectId(doc);
+      JsonObject query = JsonObject.of("$and", JsonArray.of(
+        JsonObject.of("foo", "bar"),
+        JsonObject.of("_id", objectId)));
+      mongoClient.insert(collection, doc).onComplete(onSuccess(id -> {
+        // no auto-generated objectId from mongo
+        assertNull(id);
+        mongoClient.findOne(collection, query, null).onComplete(onSuccess(obj -> {
+          assertTrue(obj.containsKey("_id"));
+          assertTrue(obj.getValue("_id") instanceof String);
+          obj.remove("_id");
+          // nested "_id" will not be modified when insert
+          assertEquals(orig, obj);
+          testComplete();
+        }));
+      }));
+    }));
+    await();
+  }
+
   @Test
   public void testFindOneReturnsNothing() throws Exception {
     String collection = randomCollection();
@@ -116,6 +143,35 @@ public void testFindReturnsStringId() throws Exception {
     await();
   }
 
+
+  @Test
+  public void testFindWithNestedQueryReturnsStringId() throws Exception {
+    String collection = randomCollection();
+    mongoClient.createCollection(collection).onComplete(onSuccess(res -> {
+      JsonObject orig = createDoc();
+      JsonObject doc = orig.copy();
+      String objectId = getObjectId(doc);
+      JsonObject query = JsonObject.of("$and", JsonArray.of(
+          JsonObject.of("foo", "bar"),
+          JsonObject.of("_id", objectId)));
+      mongoClient.insert(collection, doc).onComplete(onSuccess(id -> {
+        // no auto-generated objectId from mongo
+        assertNull(id);
+        mongoClient.find(collection, query).onComplete(onSuccess(list -> {
+          assertTrue(list.size() == 1);
+          JsonObject obj = list.get(0);
+          assertTrue(obj.containsKey("_id"));
+          assertTrue(obj.getValue("_id") instanceof String);
+          obj.remove("_id");
+          // nested "_id" will not be modified when insert
+          assertEquals(orig, obj);
+          testComplete();
+        }));
+      }));
+    }));
+    await();
+  }
+
   @Test
   @Override
   public void testInsertPreexistingObjectID() throws Exception {

diff --git a/src/test/java/io/vertx/ext/mongo/MongoTestBase.java b/src/test/java/io/vertx/ext/mongo/MongoTestBase.java
@@ -182,7 +182,14 @@ protected JsonObject createDoc() {
         .put("myarr", new JsonArray()
           .add("blah")
           .add(true)
-          .add(312)));
+          .add(312)))
+      .put("nested_id1", new JsonObject()
+        .put("_id", new ObjectId().toHexString()))
+      .put("nested_id2", new JsonArray()
+        .add(new JsonObject()
+          .put("_id", new ObjectId().toHexString()))
+        .add(new JsonObject()
+          .put("_id", new ObjectId().toHexString())));
   }
 
   protected JsonObject createDoc(int num) {
@@ -210,4 +217,28 @@ protected JsonObject createDocWithAmbiguitiesDependingOnLocale(int num) {
       .put("longval", 123456789L).put("dblval", 1.23);
   }
 
+  // WARN: try to getObjectId from doc will generate new objectId on doc if not exists
+  protected String getObjectId(JsonObject doc) {
+    Object idVal = doc.getValue("_id");
+
+    // auto generate when not exists
+    if(idVal == null) {
+      String _id = new ObjectId().toHexString();
+      doc.put("_id", JsonObject.of("$oid", _id));
+      return _id;
+    }
+
+    // return string
+    if(idVal instanceof String) {
+      return (String) idVal;
+    }
+
+    // return $oid from ObjectId object
+    if(idVal instanceof JsonObject) {
+      return ((JsonObject) idVal).getString("$oid");
+    }
+
+    return null;
+  }
+
 }