Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface for Service- Proxy&ProxyBuilder #91

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

eutkin
Copy link

@eutkin eutkin commented Mar 28, 2019

extract interfaces for base classes (ServiceBinder, ServiceProxyBuilder). Add @VertxGen for these interfaces. Made for use in rx java2.

…r). Add @VertxGen for these interfaces. Made for use in rx java2.
@eutkin eutkin changed the title Interface for Service- Proxy&ProxyBinder Interface for Service- Proxy&ProxyBuilder Mar 28, 2019
eutkin added 3 commits April 25, 2019 13:19
# Conflicts:
#	src/main/java/io/vertx/serviceproxy/ServiceBinder.java
@eutkin
Copy link
Author

eutkin commented Apr 25, 2019

anybody?

@slinkydeveloper slinkydeveloper self-requested a review May 3, 2019 07:40
@slinkydeveloper
Copy link
Member

Hi, sorry for the delay.
I don't understand why you need RxJava bindings for ServiceBinder & ServiceProxyBuilder. There are no async methods in it

@eutkin
Copy link
Author

eutkin commented May 15, 2019

this is necessary to make it easier to register proxies in verticle rx wrappers

@okou19900722
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants