Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Golang binary server & Python client. #19

Merged
merged 27 commits into from
Dec 26, 2024
Merged

Enhancement: Golang binary server & Python client. #19

merged 27 commits into from
Dec 26, 2024

Conversation

Neeraj319
Copy link
Member

@Neeraj319 Neeraj319 commented Dec 24, 2024 •
edited
Loading

Changes:

  • Golang server for client server communication.
  • Locatr protocol on top of unix sockets.
  • Python locatr client.

@Neeraj319 Neeraj319 self-assigned this Dec 24, 2024
Hungerarray
Hungerarray reviewed Dec 24, 2024
View reviewed changes
Copy link

@Hungerarray Hungerarray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While simple flat structure is ok, for basic projects, once we grow big it is recommended to use package structure. And also avoid using any utils.go. This is only general convention in go.

selenium.go Outdated Show resolved Hide resolved
server/main.go Outdated Show resolved Hide resolved
server/main.go Outdated Show resolved Hide resolved
server/main.go Outdated Show resolved Hide resolved
server/main.go Outdated Show resolved Hide resolved
server/utils.go Show resolved Hide resolved
Hungerarray
Hungerarray requested changes Dec 24, 2024
View reviewed changes
Copy link

@Hungerarray Hungerarray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments added.

@Neeraj319 Neeraj319 changed the title Enhancement: Golang binary server Enhancement: Golang binary server & Python client. Dec 26, 2024
@Neeraj319 Neeraj319 merged commit bb04d6b into main Dec 26, 2024
1 check passed
@kgritesh kgritesh deleted the feat/go-server branch January 11, 2025 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hungerarray Hungerarray Hungerarray requested changes

@CaffeineDuck CaffeineDuck Awaiting requested review from CaffeineDuck

Assignees

@Neeraj319 Neeraj319

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Neeraj319 @Hungerarray