Skip to content

Commit

Permalink
Skip step in online upgrade if not using transient (#162)
Browse files Browse the repository at this point in the history
We weren't skipping waitForReadyTransientPod if we are driving online
upgrade without a transient.  It isn't a major problem as we would error
out looking for the transient pod. But it does add some noise to the
operator log.
  • Loading branch information
spilchen authored Mar 1, 2022
1 parent f19d57c commit 1acbc98
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions pkg/controllers/onlineupgrade_reconciler.go
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,10 @@ func (o *OnlineUpgradeReconciler) addTransientNodes(ctx context.Context) (ctrl.R
// This is done so that when we direct traffic to the transient subcluster the
// service object has a pod to route too.
func (o *OnlineUpgradeReconciler) waitForReadyTransientPod(ctx context.Context) (ctrl.Result, error) {
if o.skipTransientSetup() {
return ctrl.Result{}, nil
}

pod := &corev1.Pod{}
sc := buildTransientSubcluster(o.Vdb, "")
// We only check the first pod is ready
Expand Down

0 comments on commit 1acbc98

Please sign in to comment.