Add routing label to sandbox pods #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypaulin
requested review from
cchen-vertica,
fenic-fawkes,
HaoYang0000,
qindotguan and
LiboYu2
as code owners
There was a problem hiding this comment.
Looks good. Only one concern: if we enable client-proxy and restart a client-proxy pod of a sandbox, the client-proxy pod should still have the routing label. Your code seems covered this case, but we don't have an e2e test for it. You can leave a comment in your jira to let QA test this case.
| @@ -1052,6 +1052,13 @@ func (r *OnlineUpgradeReconciler) redirectConnectionsToReplicaGroupB(ctx context | |||
| if verrors.IsReconcileAborted(res, err) { | |||
| return res, err | |||
| } | |||
| // Now that routing to the sandbox is allowed, we no longer need | |||
| // disableRouting annotation so we can safely turn it off. | |||
| sbMan := MakeSandboxConfigMapManager(r.VRec, r.VDB, r.sandboxName, "" /*no uuid*/) | |||
There was a problem hiding this comment.
We need to put space in the comment: change "/no uuid/" to "/* no uuid */". Otherwise, the new golint in new operator-sdk will fail the build.
cchen-vertica
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a sandbox pod is deleted, the operator does not put back the routing label. This adds the ClientRoutingLabelReconciler in the sandbox controller. It also adds an annotation in the configMap to sometimes disable routing, like in the case of online upgrade where routing to the sandbox must not be allowed until replication is done.