Add Arcade Editor Sample #135
Merged
+2,796
−2,995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yonabystedt
commented
Jan 21, 2025
yonabystedt
commented
- Adds a sample of using the Arcade Editor Webcomponent.
- Fixes the 'icons' sample to work with the latest webpack.
- Updates Web to 5.33
✅ Deploy Preview for vertigis-web-samples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ples into arcade.editor.sample
scottander
approved these changes
Feb 5, 2025
| // Log script change events | ||
| onArcgisScriptChange={async (e) => { | ||
| console.log("script:", e.detail); | ||
| // console.log("outputType on script:", await arcadeEditorElt.getOutputType()); |
There was a problem hiding this comment.
these console logs could be cleaned up
| }); | ||
| } | ||
|
|
||
| protected override _getSerializableProperties(): PropertyDefs<ComponentModelProperties> { |
There was a problem hiding this comment.
probably can be removed.
| protected async _executeArcadeEditorLoadData( | ||
| args: HasFeatures | ||
| ): Promise<void> { | ||
| const featureSet = new FeatureSet({ |
There was a problem hiding this comment.
Should the arcadeeditor be initially hidden and then shown when we load data?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.