fix: fixing schema for associated ids on pipedrive (#302)

vesselapi · Aug 17, 2023 · ed90916 · ed90916
1 parent 5ef575c
commit ed90916
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 8 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@vesselapi/integrations",
-  "version": "1.0.69",
+  "version": "1.0.70",
   "description": "Vessel integrations",
   "main": "dist/index.js",
   "module": "dist/index.mjs",

diff --git a/src/platforms/pipedrive/client.ts b/src/platforms/pipedrive/client.ts
@@ -55,6 +55,7 @@ const request = makeRequestFactory(async (auth, options) => {
 type requestFunctionType<I, O> = (
   auth: Auth,
   input: I,
+  options?: Parameters<ReturnType<typeof request>>[2],
 ) => Promise<ClientResult<O>>;
 
 const makeClient = () => {

diff --git a/src/platforms/pipedrive/schemas.ts b/src/platforms/pipedrive/schemas.ts
@@ -24,7 +24,7 @@ export type FindOutput<T> = {
   data: T;
 };
 export type ListOutput<T> = {
-  data?: T[];
+  data?: T[] | null;
   additional_data?: {
     pagination?: { more_items_in_collection?: boolean; start?: number };
   };
@@ -39,7 +39,7 @@ export const listResponseSchema = <TOutput>(
   itemSchema: z.ZodType<TOutput, any, any>,
 ) =>
   z.object({
-    data: z.array(itemSchema).optional(),
+    data: z.array(itemSchema).optional().nullable(),
     additional_data: z
       .object({
         pagination: z
@@ -119,6 +119,8 @@ export const pipedriveAssociationId = z.object({
   name: z.string(),
 });
 
+export const pipedriveStringOrNumber = () => z.union([z.string(), z.number()]);
+
 // -
 // Users
 // -
@@ -262,12 +264,12 @@ export const pipedriveNoteSchema = custom.addNativeToZodSchema(
     add_time: custom.date(),
     update_time: custom.date(),
     content: z.string().nullable(),
-    user_id: z.number().nullable(),
+    user_id: pipedriveStringOrNumber().nullable(),
     active_flag: z.boolean().nullable(),
-    deal_id: z.number().optional().nullable(),
-    person_id: z.number().optional().nullable(),
-    org_id: z.number().optional().nullable(),
-    lead_id: z.number().optional().nullable(),
+    deal_id: pipedriveStringOrNumber().optional().nullable(),
+    person_id: pipedriveStringOrNumber().optional().nullable(),
+    org_id: pipedriveStringOrNumber().optional().nullable(),
+    lead_id: pipedriveStringOrNumber().optional().nullable(),
   }),
 );
 export type PipedriveNote = z.infer<typeof pipedriveNoteSchema>;