chore: Fix build check (#36)

* Replace build:changes with typecheck

* fix typing

.github/workflows/pr-checks.yml

@@ -17,7 +17,7 @@ jobs:
       - name: Setup environment
         uses: ./.github/actions/setup-composite
       - run: pnpm format:check
-      - run: pnpm build:changes
+      - run: pnpm typecheck
   verify-env-vars:
     name: Verify environment variables are on dev and prod
     runs-on: ubuntu-latest

apps/backend/package.json

@@ -22,8 +22,7 @@
     "@vessel/prettier-config": "workspace:^0.1.0",
     "@vessel/types": "workspace:^0.1.0",
     "@vessel/tsconfig": "workspace:^0.1.0",
-    "aws-cdk-lib": "2.101.1",
-    "constructs": "10.2.69",
+    "aws-cdk-lib": "2.110.1",
     "dotenv-cli": "^7.3.0",
     "eslint": "^8.53.0",
     "prettier": "^3.0.3",

apps/backend/src/stacks/CoreStack.ts

@@ -51,7 +51,6 @@ export function CoreStack({ stack }: StackContext) {
     },
   });
 
-  // Step function for alerting oncall
   const alertPageWaitTask = new Wait(stack, 'AlertPageWaitTask', {
     time: WaitTime.secondsPath('$.waitSeconds'),
   });

package.json

@@ -7,7 +7,6 @@
   "packageManager": "[email protected]",
   "scripts": {
     "build": "turbo build",
-    "build:changes": "turbo run build --filter=\"...[origin/main]\"",
     "clean": "git clean -xdf node_modules",
     "clean:workspaces": "turbo clean",
     "postinstall": "pnpm lint:ws",

packages/api/src/router/alert/alert-by-id.ts

@@ -28,5 +28,8 @@ export const alertById = trpc
   .input(input)
   .query(async ({ ctx, input }) => {
     const dbAlert = await ctx.db.alerts.find(input.id);
+    if (!dbAlert) {
+      return null;
+    }
     return createAlertView(dbAlert);
   });

packages/api/src/router/alert/alert.view.ts

@@ -1,8 +1,6 @@
 import type { Alert } from '@vessel/db/schema/alert';
 
-export const createAlertView = (dbAlert: Alert | null) => {
-  if (!dbAlert) return dbAlert;
-
+export const createAlertView = (dbAlert: Alert) => {
   return {
     ...dbAlert,
     summary: `Alert '${dbAlert.title}' triggered by ${dbAlert.source}`,

packages/api/src/services/user-manager.ts

@@ -18,7 +18,8 @@ export const makeUserManager = () => {
     const put = async ({ id, url }: { id: UserId; url: string }) => {
       const key = PROFILE_PIC_S3_PATH(id);
       const res = await fetch(url);
-      await blobStore.put({ key, data: await res.arrayBuffer() });
+      const buf = Buffer.from(new Uint8Array(await res.arrayBuffer()));
+      await blobStore.put({ key, data: buf });
       return { key };
     };
     const addToUser = async (user: User) => {