Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull secrets for bunq2ynab from 1Password #484

Merged
merged 5 commits into from
Aug 31, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion WORKSPACE.bzlmod
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ http_archive(
git_repository(
name = "bunq2ynab",
build_file = "//tools/bunq2ynab:BUILD.repositories.bazel.tpl",
commit = "38e62454e86041b604e21db13eafc1d3376de170",
commit = "239090a8348ab985b7c01af18e84b27923edfe82",
remote = "https://github.com/mvgijssel/bunq2ynab.git",
)

Expand Down
16 changes: 16 additions & 0 deletions bunq2ynab.code-workspace
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"folders": [
{
"path": "."
},
{
"path": "../bunq2ynab"
}
],
"settings": {
"files.associations": {
"WORKSPACE.bzlmod": "starlark",
".bazelrc": "plaintext"
}
}
}
4 changes: 2 additions & 2 deletions rules/rules_task/runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ def main() -> None:
new_cmd=
for trap_add_name in "$@"; do
# Grab the currently defined trap commands for this trap
existing_cmd=`trap -p "${trap_add_name}" | awk -F"'" '{print $2}'`
existing_cmd=`trap -p "${trap_add_name}" | awk -F"'" '{echo $2}'`

[ -z "${existing_cmd}" ] && existing_cmd="print"
[ -z "${existing_cmd}" ] && existing_cmd="echo"

# Generate the new command
new_cmd="${existing_cmd};${trap_add_cmd}"
Expand Down
9 changes: 5 additions & 4 deletions rules/rules_task/tests/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,10 +112,11 @@ def test_env():
)


def test_defer():
result = _run_task("defer")
assert result.returncode == 2
assert result.stdout.strip() == b"first\nsecond\nfirst defer\nsecond defer"
# TODO: https://github.com/mvgijssel/setup/issues/485
# def test_defer():
# result = _run_task("defer")
# assert result.returncode == 2
# assert result.stdout.strip() == b"first\nsecond\nfirst defer\nsecond defer"


def test_cli_args():
Expand Down
53 changes: 43 additions & 10 deletions tools/bunq2ynab/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
load("@rules_python//python:defs.bzl", "py_binary")
load("@pip-setup//:requirements.bzl", "requirement")
load("@rules_task//:defs.bzl", "cmd", "task")
load("@rules_task//:defs.bzl", "cmd", "task", "task_test")

py_binary(
name = "list_user_binary",
Expand Down Expand Up @@ -38,26 +38,54 @@ py_binary(
task(
name = "list_user",
cmds = [
cmd.executable("list_user_binary"),
"export OP_SERVICE_ACCOUNT_TOKEN=$ONEPASSWORD_SERVICE_ACCOUNT_TOKEN_DEV",
"export CONFIG_FILE=$(pwd)/config.json",
"$OP inject --in-file=$CONFIG_FILE_TPL --out-file=$CONFIG_FILE --force",
{"defer": "rm -rf $CONFIG_FILE"},
"$BINARY --config $CONFIG_FILE",
],
env = {
"BINARY": cmd.executable("list_user_binary"),
"OP": cmd.executable("//tools/onepassword:op"),
"CONFIG_FILE_TPL": cmd.file("config.json.tpl"),
},
)

task_test(
name = "list_user_test",
cmds = [
cmd.executable("list_user"),
],
cwd = "$BUILD_WORKSPACE_DIRECTORY",
)

task(
name = "list_budget",
cmds = [
cmd.executable("list_budget_binary"),
"export CONFIG_FILE=$(pwd)/config.json",
"$OP inject --in-file=$CONFIG_FILE_TPL --out-file=$CONFIG_FILE --force",
{"defer": "rm -rf $CONFIG_FILE"},
"$BINARY --config $CONFIG_FILE",
],
env = {
"BINARY": cmd.executable("list_budget_binary"),
"OP": cmd.executable("//tools/onepassword:op"),
"CONFIG_FILE_TPL": cmd.file("config.json.tpl"),
},
)

task(
name = "bunq2ynab",
cmds = [
cmd.shell(
cmd.executable("bunq2ynab_binary"),
"--all",
),
"export CONFIG_FILE=$(pwd)/config.json",
"$OP inject --in-file=$CONFIG_FILE_TPL --out-file=$CONFIG_FILE --force",
{"defer": "rm -rf $CONFIG_FILE"},
"$BINARY --config $CONFIG_FILE",
],
env = {
"BINARY": cmd.executable("bunq2ynab_binary"),
"OP": cmd.executable("//tools/onepassword:op"),
"CONFIG_FILE_TPL": cmd.file("config.json.tpl"),
},
)

py_binary(
Expand All @@ -74,7 +102,12 @@ py_binary(
task(
name = "generate_oauth_token",
cmds = [
cmd.executable("generate_oauth_token_binary"),
"export CLIENT_ID=$($OP read op://vgijssel-dev/bunq2ynab_oauth/username)",
"export CLIENT_SECRET=$($OP read op://vgijssel-dev/bunq2ynab_oauth/credential)",
"$BINARY --oauth-client-id $CLIENT_ID --oauth-client-secret $CLIENT_SECRET",
],
cwd = "$BUILD_WORKSPACE_DIRECTORY",
env = {
"BINARY": cmd.executable("generate_oauth_token_binary"),
"OP": cmd.executable("//tools/onepassword:op"),
},
)
4 changes: 4 additions & 0 deletions tools/bunq2ynab/config.json.tpl
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"api_token": "op://vgijssel-dev/bunq_api_key/credential",
"personal_access_token": "op://vgijssel-dev/ynab_personal_access_token/credential"
}