Improve snapshotting functionality #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns and restorations Signed-off-by: Amory Hoste <[email protected]>
…pace Signed-off-by: Amory Hoste <[email protected]>
…m network namespace Signed-off-by: Amory Hoste <[email protected]>
…pshots Signed-off-by: Amory Hoste <[email protected]>
Signed-off-by: Amory Hoste <[email protected]>
ustiugov
requested changes
Dec 1, 2021
proto/types.proto
Outdated
| @@ -98,11 +98,12 @@ message IPConfiguration { | |||
| message FirecrackerMachineConfiguration { | |||
| string CPUTemplate = 1; // Specifies the cpu template. Example: "T2" or "C3" | |||
| bool HtEnabled = 2; // Specifies if hyper-threading should be enabled | |||
| bool TrackDirtyPages = 3; // Specified if dirty-page-tracking should be enabled. | |||
There was a problem hiding this comment.
please move to the 5th position to allow backwards compatibility.
proto/types.proto
Outdated
| // Specifies the memory size of VM | ||
| // This lets us create a Firecracker VM of up to 4096 TiB, which | ||
| // for a microVM should be large enough | ||
| uint32 MemSizeMib = 3; | ||
| uint32 VcpuCount = 4; // Specifies the number of vCPUs for the VM | ||
| uint32 MemSizeMib = 4; |
runtime/service.go
Outdated
| @@ -268,20 +274,22 @@ func (s *service) startEventForwarders(remotePublisher shim.Publisher) { | |||
| go func() { | |||
| <-s.vmReady | |||
|
|
|||
| // Once the VM is ready, also start forwarding events from it to our exchange | |||
| attachCh := eventbridge.Attach(ctx, s.eventBridgeClient, s.eventExchange) | |||
| if ! s.snapLoaded { | |||
There was a problem hiding this comment.
refactor for a better code style:
if s.snapLoaded { return }
<...> // everything just like before but without an indent
runtime/service.go
Outdated
| return &empty.Empty{}, nil | ||
| } | ||
|
|
||
| // shutdownSnapLoadedVm shuts down a vm that has been loaded from a snapshot | ||
| func (s *service) shutdownSnapLoadedVm() error { | ||
| // Kill firecracker process and its shild processes |
There was a problem hiding this comment.
Suggested change
| // Kill firecracker process and its shild processes | |
| // Kill firecracker process and its child processes |
runtime/service.go
Outdated
| DialTimeout: 100 * time.Millisecond, | ||
| RequestTimeout: 10 * time.Second, | ||
| ResponseHeaderTimeout: 10 * time.Second, | ||
| DialTimeout: 1000 * time.Millisecond, |
There was a problem hiding this comment.
is there a reason for this timeout increasing? why to those values?
There was a problem hiding this comment.
I noticed some timeouts when restoring or loading snapshots, as far as I remember especially for larger memory sizes which makes sense. The values are chosen quite arbitrarily.
There was a problem hiding this comment.
try decreasing them (e.g., try 2x vs 10x as of now). large timeouts create issues in the control plane, the system becomes less responsive
runtime/service.go
Outdated
| } | ||
|
|
||
| // Offload Shuts down a VM and deletes the corresponding firecracker socket | ||
| // and vsock. All of the other resources will persist | ||
| // and vsock. All of the other resources will persist. Depracated! |
There was a problem hiding this comment.
Suggested change
| // and vsock. All of the other resources will persist. Depracated! | |
| // and vsock. All of the other resources will persist. DEPRECATED! |
Signed-off-by: Amory Hoste <[email protected]>
amohoste
force-pushed
the
v0.25_reference
branch
from
d6e4a75 to
aff3d2b
Compare
amohoste
force-pushed
the
v0.25_reference
branch
7 times, most recently
from
0e94206 to
032bd10
Compare
Signed-off-by: Amory Hoste <[email protected]>
amohoste
force-pushed
the
v0.25_reference
branch
from
032bd10 to
45eba1d
Compare
Signed-off-by: Amory Hoste <[email protected]>
…cker-containerd into v0.25_reference Signed-off-by: Amory Hoste <[email protected]>
amohoste
force-pushed
the
v0.25_reference
branch
from
ec1680b to
19c96c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following changes