Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firecracker v1.4.1 vhive integration #43

Open
wants to merge 5 commits into
base: firecracker-v1.4.1-vhive-integration
Choose a base branch
from
Open

Firecracker v1.4.1 vhive integration #43

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fad2f75
Add memory backend for CreateVMRequest
char-1ee Oct 9, 2023
3346214
Update memory backend in runtime service
char-1ee Oct 9, 2023
d0ef8a3
Fix typo
char-1ee Oct 12, 2023
49cac5e
Fix mismatch LoadSnapshot parameters
char-1ee Oct 18, 2023
6cc7736
Fix exclusion of memory backend
char-1ee Feb 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
152 changes: 81 additions & 71 deletions proto/firecracker.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions proto/firecracker.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,18 @@ message CreateVMRequest {

// Whether the VM should be created by loading a snapshot.
bool LoadSnapshot = 16;

// Path to the file that contains the guest memory to be loaded.
string MemFilePath = 17;

// Path to the file that contains the VM state to be loaded.
string SnapshotPath = 18;

// Path to the disk device backing the container snapshot.
string ContainerSnapshotPath = 19;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: please drop the blank lines here and above from the diff.

// Configuration for the backend that handles memory load. If this field is specified, `mem_file_path` is forbidden. Either `mem_backend` or `mem_file_path` must be present at a time.
MemoryBackend MemBackend = 20;
}

message CreateVMResponse {
Expand Down
Loading