-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finer reference trace #325
Conversation
numpy==1.24.4 | ||
pandas==1.3.5 | ||
scipy==1.11.2 | ||
scipy==1.10.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cvetkovic We noticed that this bump of numpy and scipy versions make it impossible to use sampler on Ubuntu 20.04 (I think that's the reason, but might be other factor). Do you know a proper way of fixing that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is due to the Python version, but still, the Python version is linked to the Ubuntu version which is annoying, so I lowered the dependency versions. The numpy 1.26.1 and scipy 1.10.1 require Python 3.9, and we don't have that as default on Ubuntu 20.04
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for now but we need to move to using ubuntu 22 for measurements. this is about time but we need to plan this upgrade vHive-wide.
2b10a01
to
7c3d3ed
Compare
7914059
to
10ef270
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor things and can merge
numpy==1.24.4 | ||
pandas==1.3.5 | ||
scipy==1.11.2 | ||
scipy==1.10.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok for now but we need to move to using ubuntu 22 for measurements. this is about time but we need to plan this upgrade vHive-wide.
16d4712
to
58441c1
Compare
Signed-off-by: JooYoung Park <[email protected]> add finer-step reference trace Signed-off-by: JooYoung Park <[email protected]> added number of function suggestion to cores Signed-off-by: JooYoung Park <[email protected]> fix wordlist Signed-off-by: JooYoung Park <[email protected]> fixed docs Signed-off-by: JooYoung Park <[email protected]> add word to wordlist Signed-off-by: JooYoung Park <[email protected]> fix doc Signed-off-by: JooYoung Park <[email protected]> Update reference traces docs Signed-off-by: Leonid Kondrashov <[email protected]> Update docs/loader.md Co-authored-by: Dmitrii Ustiugov <[email protected]> resampled the reference traces that were sampled wrongly Signed-off-by: JooYoung Park <[email protected]> removed statistics from sampled traces Signed-off-by: JooYoung Park <[email protected]>
58441c1
to
c724a4b
Compare
Summary
Add the finer number of sampled functions for the step of 10 functions between 10-200 functions.
Add suggestion of number of functions to replay relative to the number of cores (5 functions per core, 80 for 16-core D430)
Also, fix recent dependabot bump in python package versions creating dependency issue with Python 3.8 in vHive20 image, and gitignore to properly ignore only csv files.