Feature: Added creating of Directed Acyclic Graphs (DAG) to existing DAG Driver #433

NotAnAddictz · 2024-05-22T16:10:19Z

Summary

Previously, in PR #383 , we added functionality for sequential invocation for each function. This commit adds on to this existing feature, making every function act as an entry point and create a DAG structure for each function based on the width and depth distributions in data/traces/example/dag_structure.xlsx and invoke it according to the frequency of the entry functions.

Implementation Notes ⚒️

Added various helper functions to create and manage the DAG structure.
Added functionality to download the sampled_150 folder containing the folders for each group of functions if required.
Tweaked the generation of specifications for each function to cover the highest possible invocation frequencies/min
Wrapped the functions into Nodes to facilitate DAG generation
Added parameter entriesWritten to functionsDriver to ensure all invocations are written in the output file
Added a retry limit of 1 for each function in the DAG.
All DAG Structures will not have duplicate functions inside it, and is populated by randomly chosen functions in the function list.

External Dependencies 🍀

N/A

Breaking API Changes ⚠️

N/A

Simply specify none (N/A) if not applicable.

cvetkovic · 2024-07-16T10:34:17Z

@leokondrashov: Is this still relevant or we close this PR?

wanghanchengchn · 2024-07-16T11:23:34Z

@leokondrashov: Is this still relevant or we close this PR?

I apologize for the late reply. I will review this pull request!

pkg/config/parser.go

pkg/driver/trace_driver.go

wanghanchengchn · 2024-08-30T04:08:42Z

Dear @cvetkovic,

The current version looks good to me. However, due to my limited experience in reviewing pull requests, I would greatly appreciate it if you could provide us with some feedback when you have a moment. Thank you very much!

cmd/loader.go

data/traces/example/dag_structure.xlsx

pkg/config/parser.go

pkg/driver/trace_driver.go

cvetkovic

LGTM. @leokondrashov If good, you can proceed with merging.

cvetkovic · 2024-10-04T15:43:18Z

@wanghanchengchn Just fix the errors linter reports.

wanghanchengchn · 2024-10-04T19:19:48Z

Thank you! Dear @NotAnAddictz, could you please address the failed checks? Additionally, this branch is out-of-date with the base branch. Kindly rebase on the main branch and verify that all checks are passing. Thank you!

leokondrashov

Looks good to me codewise. But I'd like to have documentation for the feature in the repo, not only in the PR description.

I think the linter problem is not caused by you, but it's easy to fix by changing Fatalf to Fatal.

cmd/config.json

docs/configuration.md

leokondrashov

The code looks good to me. I have a couple of suggestions for tests: failure to generate, correct depth and width of bigger DAGs with multiple branches, reading and generating the sizes from trace file, creation of several DAGs.

NotAnAddictz · 2024-11-26T13:28:36Z

Thanks for the suggestions! Have added tests to generate from trace, multiple DAG generation of bigger DAGs (width = 10, depth 5)

leokondrashov

Please fix couple minor things

leokondrashov · 2024-11-27T05:45:18Z

pkg/driver/trace_driver.go

+		if d.Configuration.LoaderConfiguration.AsyncMode {
+			sleepFor := time.Duration(d.Configuration.LoaderConfiguration.AsyncWaitToCollectMin) * time.Minute
+
+			log.Infof("Sleeping for %v...", sleepFor)
+			time.Sleep(sleepFor)
+
+			d.writeAsyncRecordsToLog(globalMetricsCollector)
+		}
+


Duplicated lines, look above

leokondrashov · 2024-11-27T06:49:29Z

pkg/driver/trace_driver.go

 		node = node.Next()
 	}
+	atomic.AddInt64(metadata.FunctionsInvoked, numberOfFunctionsInvoked)
 	if success {
 		atomic.AddInt64(metadata.SuccessCount, 1)


This now counts successful branch execution, not DAG or functions. I don't think that would be the correct behaviour.

Noted, have changed to reflect successful functions invoked.

leokondrashov · 2024-11-27T07:02:36Z

pkg/driver/trace_driver_test.go

 		RecordOutputChannel: invocationRecordOutputChannel,
 		AnnounceDoneWG:      announceDone,
 	}

 	announceDone.Add(1)
 	testDriver.invokeFunction(metadata)
-	if !(successCount == 1 && failureCount == 0) {
+	announceDone.Wait()
+	if !(functionsInvoked == 3 && failureCount == 0) {


Consider adding the successCount test as well. I think it might be handled wrongly (see previous comment).

leokondrashov · 2024-11-27T07:06:18Z

pkg/driver/trace_driver_test.go

@@ -135,7 +136,7 @@ func TestInvokeFunctionFromDriver(t *testing.T) {

 			testDriver := createTestDriver()
 			var failureCountByMinute = make([]int64, testDriver.Configuration.TraceDuration)
-
+			var functionsInvoked int64


Please also add it into test conditions.

leokondrashov · 2024-11-27T07:16:30Z

docs/configuration.md

@@ -33,7 +33,10 @@
 | MetricScrapingPeriodSeconds  | int       | > 0                                                                 | 15                  | Period of Prometheus metrics scrapping                                               |
 | GRPCConnectionTimeoutSeconds | int       | > 0                                                                 | 60                  | Timeout for establishing a gRPC connection                                           |
 | GRPCFunctionTimeoutSeconds   | int       | > 0                                                                 | 90                  | Maximum time given to function to execute[^5]                                        |
-| DAGMode                      | bool      | true/false                                                          | false               | Sequential invocation of all functions one after another                             |
+| DAGMode                      | bool      | true/false                                                          | false               | Generates DAG workflows iteratively with functions in TracePath [^7]. Frequency and IAT of the DAG follows their respective entry function, while Duration and Memory of each function will follow their respective values in TracePath.                                                                                                              |                            
+| EnableDAGDataset             | bool      | true/false                                                          | true                |  Generate width and depth from data/traces/example/dag_structure.csv[^8]                                                                                                      |


Update that the generation will take the .csv file from the trace path, not from that specific one. This one is the sample, not the data that should be used in real experiments.

leokondrashov

LGTM now. Thank you, YiShen, for patiently following all my suggestions.

@cvetkovic We would need to plan the merge around the merge of RPS mode. Can you assist in that?

@NotAnAddictz Unfortunately, this might require another rebase of the trace driver. But it should be pretty small because the RPS mode mostly changes the functionsDriver, while yours is mostly in the invoker part.

leokondrashov

Thanks for the timely update. It looks good to me, @cvetkovic please merge it if you don't have any further comments.

cvetkovic · 2024-12-10T09:56:28Z

data/traces/example/dag_structure.csv

@@ -0,0 +1,6 @@
+Width,Width - Percentile,Depth,Depth - Percentile,Total Nodes,Total Nodes


Please change the column names to Width,WidthPercentile,Depth,DepthPercentile,TotalNodes,TotalNodes. We might have parsing problems on different systems.

cvetkovic · 2024-12-10T10:08:51Z

@leokondrashov: Just a minor comment. After that we are ready to merge.

Signed-off-by: Kway Yi Shen <[email protected]>

NotAnAddictz force-pushed the main branch 2 times, most recently from d9e9ef0 to 9161a77 Compare May 22, 2024 16:25

wanghanchengchn reviewed Jul 17, 2024

View reviewed changes

pkg/config/parser.go Outdated Show resolved Hide resolved

wanghanchengchn reviewed Jul 17, 2024

View reviewed changes