Async invoke and collect results in Dirigent #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
What are you trying to do? Based on the brief look at the code, you invoke the usual way (synchronously, grpc or HTTP, since the invoker didn't change) but collect the responses to write to files asynchronously. This doesn't add up with the PR name, though. So, please add the description to resolve this confusion.
cvetkovic
force-pushed
the
dirigent_async_requests
branch
2 times, most recently
from
75512c6 to
f2687e2
Compare
cvetkovic
force-pushed
the
dirigent_async_requests
branch
2 times, most recently
from
7c64654 to
881919e
Compare
cvetkovic
changed the title
cvetkovic
force-pushed
the
dirigent_async_requests
branch
2 times, most recently
from
96b30c3 to
d71a9b1
Compare
Signed-off-by: Lazar Cvetković <[email protected]>
Signed-off-by: Lazar Cvetković <[email protected]>
Signed-off-by: Lazar Cvetković <[email protected]>
cvetkovic
force-pushed
the
dirigent_async_requests
branch
from
d71a9b1 to
5eec3f8
Compare
leokondrashov
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.